Repository navigation
docs(assets): remove the two README images nothing uses - #353
Merged
Merged
Conversation
docs/assets/coffee-flow.png and docs/assets/mmo-focus.png have had no reference since the README's Screenshots section was rewritten in #207 (v0.10.0); #327 re-shot them anyway. No tracked file names either one (searched by file stem, spelling variants and the docs/assets folder in code, scripts, tests, configuration and docs). The three images the README shows (hero-coffee, gacha-overview, gacha-pickup-guarantee) stay. Removed from the current tree only; both files remain in the history, the tags and the Releases. Nothing built or shipped changes, so no change declaration is needed (check:change-declaration passes).
Deploying cozy-loop-studio with
|
| Latest commit: |
b317ff8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a011fbc.cozy-loop-studio.pages.dev |
| Branch Preview URL: | https://docs-remove-unused-readme-as.cozy-loop-studio.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the two README images nothing uses
docs/assets/coffee-flow.pnganddocs/assets/mmo-focus.pngare removed from the current tree. Neither has been referenced since the README's Screenshots section was rewritten in #207 (v0.10.0); #327 re-shot both anyway.What was checked
main(code, scripts, tests, configuration, docs) was searched for each file's stem (coffee-flow,mmo-focus), for spelling variants (coffee.flow,mmo_focus,coffeeFlow,mmoFocus) and for references to thedocs/assetsfolder as a whole. Neither file is named anywhere.hero-coffee.png,gacha-overview.png,gacha-pickup-guarantee.png.check:change-declaration: nothing built or shipped changes, so no declaration is needed.Kept
The history, the tags and the Releases are left as they are; both files remain reachable there. Nothing is rewritten.
Note
The screenshot script used for #325, which lives outside this repository, still writes both files when it is run. A later re-shoot with it would recreate them in
docs/assets/; they should not be committed again unless the README starts using them.