Repository navigation
Merge Icon Colorization - EXO-90342 - eXIP7.3.0.31 - #670
Merged
Merged
Conversation
Contributor
Author
Reviewer's evidence — eXIP 7.3.0.31 Icon Colorization backport to
|
boubaker
approved these changes
Oct 12, 2026
**Why** eXIP 7.3.0.31 US07 (EXO-90340): every icon honours the configured icon colour. The Tasks icons that still carried a neutral hard-coded colour are rebased on platform-ui's `@iconColor` chain, `var(--appIconColor, var(--allPagesBaseIconColor, <built-in>))`, so they follow the container keys of US02 and US03 and keep the platform grey when none is set. **How** - `tasks.less`, `tasksDrawer.less`, `tasksCommentDrawer.less`: plus, dots, arrows, mobile filter, breadcrumb, back-arrow and assign icons on `@iconColor`. - `TasksViewSwitcher.vue`, `ProjectCardFront.vue`, `TasksViewToolbar.vue`: the view switcher, project menu and filter icons lose `text-light-color`; the filter icons keep `primary--text` when active. Left as they are: the labelled quick-add button, empty-state icons, hover whites, primary checkbox and date icons, disabled states, favourite stars. Verified: Less compiles and the war builds; deployed on a local server. Knowledge: owed at the `feature/mips` integration PR — the US07 audit's two lessons (a text helper class painting an icon outside the chain, an SVG image used as an icon) go to the eng-standards PR the delivery owes. This change is classified N3 at 89d5d6b: no REST/DAO/schema/ACL surface touched (`classification.md` §3), stylesheet and template changes only; the delivery is N1 by max-severity at the `feature/mips` integration PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 2d714ca) (cherry picked from commit 306024f)
…XO-90342 The two icons sit in an unlabelled plain v-btn, where Vuetify's .v-btn__content .v-icon rule makes them inherit the button colour. The icon-default-color helper binds them to the icon colour chain. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit 36df6fb)
MayTekayaa
force-pushed
the
backport/EXO-90342-icon-colorization
branch
from
October 12, 2026 16:40
fb638b5 to
ee39bb7
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eXIP 7.3.0.31 — Icon Colorization
Integration PR of the eXip onto
feature/mips. Tech Spec: note 51586 — board: project 8381 (every story Tested & Validated on the devx acceptance server; US08's D8 and the D6 placeholder ruling await the spec resync).Classification: N1 at eec96b6 — the
/classifyrun over the full eXip diff of the delivery branches againstfeature/mips, confirming the Tech Spec's proposal: administrator- and editor-entered colour values rendered for every viewer (the branding stylesheet, the inline--appIconColor), with layout'sLayoutStyleValidatorrewritten on that trust boundary and extended to the site layout save; the portal attribute and theme keys N2 on their own, the rest N3 — max-severity over the full diff. Perai-review-and-merge.md§5: the approver must be an Architect/Senior Developer who knows this is N1, not an approval on AI review alone; author ≠ approver.Release order: platform-ui → commons-exo → portal → social → layout → digital-workplace, then the audit PRs (agenda, analytics, app-center, content, documents, gamification, notes, onlyoffice, processes, task, wallet) in any order. One PR per repo, same eXip; the cherry-picks are
cherry-pick -xof thefeature/devxcommits ontofeature/mips, diff-identical to the validated devx state on every touched file, no POM touched; the declared commits listed below, where present, are review fixes made on this branch.Knowledge: Meeds-io/eng-standards#222 and #233 (the ledger pitfalls of the eXip, drafts until
develop), and Meeds-io/eng-standards#321 (the domain refresh of portal, platform-ui, social and layout with four delivery checks, draft untildevelop).This repo: the task icons rebased on the icon colour cascade: hard-coded greys and
colorprops replaced by the skin's@iconColorchain and helpers (US07 audit).Commits (cherry-picked from
feature/devx)Declared commits (review fixes on this branch)
icon-default-coloron the two icons of the switcher button🤖 Generated with Claude Code