Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sqlit/shared/ui/screens/file_picker.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@
from sqlit.shared.ui.widgets import Dialog


class _FilePickerEntryLabel(Static):
"""Render a file-picker entry without enabling Textual text selection."""

ALLOW_SELECT = False


class FilePickerMode(Enum):
"""Mode for the file picker dialog."""

Expand Down Expand Up @@ -191,27 +197,27 @@ async def _refresh_file_list(self, update_input: bool = True) -> None:

# Add parent directory entry
if self._current_dir.parent != self._current_dir:
item = ListItem(Static("📁 .."))
item = ListItem(_FilePickerEntryLabel("📁 .."))
items.append(item)
self._entries.append(None) # None = parent

# Get directory contents
try:
entries = sorted(self._current_dir.iterdir(), key=lambda p: (not p.is_dir(), p.name.lower()))
except PermissionError:
items.append(ListItem(Static("⚠️ Permission denied")))
items.append(ListItem(_FilePickerEntryLabel("⚠️ Permission denied")))
await list_view.extend(items)
return

for entry in entries:
if entry.name.startswith("."):
continue # Skip hidden files
if entry.is_dir():
item = ListItem(Static(f"📁 {entry.name}"))
item = ListItem(_FilePickerEntryLabel(f"📁 {entry.name}"))
items.append(item)
self._entries.append(entry)
elif show_files and self._matches_extension(entry):
item = ListItem(Static(f"📄 {entry.name}"))
item = ListItem(_FilePickerEntryLabel(f"📄 {entry.name}"))
items.append(item)
self._entries.append(entry)

Expand Down
47 changes: 47 additions & 0 deletions tests/ui/test_file_picker.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
"""UI tests for the shared file picker."""

from __future__ import annotations

from pathlib import Path

import pytest
from textual.app import App
from textual.widgets import Static

from sqlit.shared.ui.screens.file_picker import FilePickerMode, FilePickerScreen


class _FilePickerApp(App[None]):
def __init__(self, start_directory: Path) -> None:
super().__init__()
self.start_directory = start_directory

async def on_mount(self) -> None:
await self.push_screen(
FilePickerScreen(
mode=FilePickerMode.SAVE,
start_directory=self.start_directory,
)
)


@pytest.mark.asyncio
async def test_file_picker_rows_are_not_text_selectable_and_mouse_navigation_works(
tmp_path: Path,
) -> None:
child = tmp_path / "child"
child.mkdir()
app = _FilePickerApp(tmp_path)

async with app.run_test(size=(100, 35)) as pilot:
screen = app.screen
labels = list(screen.query(Static))

assert labels
assert all(not label.allow_select for label in labels)

child_label = next(label for label in labels if "child" in str(label.render()))
await pilot.click(child_label)
await pilot.pause()

assert screen._current_dir == child