Repository navigation
♻️ Clean up Paper integration and support Minecraft 26.3 - #254
Merged
Merged
Conversation
- Require Paper 1.21.4 or newer and remove the 1.20.6, 1.21, 1.21.1 and 1.21.3 NMS modules. - Remove unused Spigot implementations and redundant platform checks. - Use Paper APIs for chat, menus, enchantments and plugin metadata. - Fix duplicate death message module registration and custom item name handling. - Fix version comparisons, incomplete downloads and resource cleanup. - Preserve GroupeZ Gradle conventions and remove obsolete version metadata and unused test dependencies. - Verify plugin packaging and Discord bot compilation.
- Add and package a dedicated Paper 26.3 NMS module using the Java 25 toolchain. - Adapt hologram entity tracking and item conversion to Minecraft 26.3. - Preserve the Paper 1.21.4 common API and existing version-specific modules. - Extend ignore rules for IDE files, Kotlin caches and local development tools. - Preserve Gradle wrapper, library JAR and source directory exceptions. - Verify plugin compilation, deployment and temporary hologram loading on the 26.3 server.
- Resolve and list vanilla, datapack and plugin enchantments directly from the server registry. - Remove manual enchantment registration, aliases and their wrapper types. - Show vanilla enchantment names without the minecraft namespace in completion suggestions. - Preserve custom namespaces and accept explicit namespaced keys. - Return Bukkit enchantments directly and update the command and item placeholders. - Verify plugin and API compilation against the Paper 1.21.4 baseline.
- Accept vanilla item identifiers with or without the minecraft namespace. - Suggest canonical item names without the namespace and exclude non-item materials and air. - Preserve configured custom items and their lookup priority. - Use translatable item and material names in give, mailbox, vault and utility feedback. - Preserve custom item names and formatting through the effective item name. - Share item name formatting and remove duplicate mailbox and vault formatting. - Verify plugin compilation against Paper 1.21.4; in-game validation remains pending.
- Use the enchant placeholder in the unknown enchantment message across the API and all translations. - Use the correct feedback message for hologram text shadows. - Provide the missing duration placeholder in kick notifications. - Provide sender, duration and creation date placeholders in kick-all notifications. - Verify plugin and API compilation.
- Remove 40 unused imports and 6 duplicate imports across the project. - Clean up blank lines left by removed imports without changing behavior. - Verify plugin, API and Discord bot compilation.
- Summarize Paper support, command improvements and fixes under Unreleased. - Document enchantment API and message placeholder changes. - Update the list of planned features.
- Build custom mailbox items with an offline player context. - Clear cached custom items before reloading their configuration. - Align mailbox and vault item suggestions with give commands. - Preserve custom enchantment namespaces in item placeholders. - Verify plugin compilation and functional checks on the 26.3 test server.
- Align bug reports with supported Minecraft versions and storage types. - Request clear environment details, reproduction steps and latest.log links through mclo.gs. - Simplify feature requests and refresh support links. - Update planned features and issue references in the changelog. - Validate the YAML files and form structure locally.
- Restore and deprecate the legacy enchantment wrapper and lookup signature. - Keep register callable as a no-op for compatibility. - Add getEnchantment for direct Bukkit enchantment lookup and migrate internal callers. - Update the changelog to describe the deprecation path. - Verify compilation, original public signatures and legacy consumer compilation.
- Update the list of planned features.
- Centralize dependency and build plugin versions in a Gradle version catalog. - Update Gradle to 9.8.2, Shadow to 9.6.1 and paperweight to 2.0.0-beta.24. - Target Java 25 in the 26.x NMS modules and preserve Java 21 for common code. - Preserve library relocations in the Discord bot and update the changelog.
- Update Sarah to 1.26 and inherit its SQL and mapping fixes. - Add max-lifetime configuration with global database settings support. - Simplify SQLite column migrations using Sarah’s native handling. - Update the changelog.
- Update the Discord bot to SnakeYAML 2.7. - Replace the removed Base64Coder utility with the Java Base64 decoder. - Preserve multiline Base64 decoding and update the changelog.
- Update the Discord bot to JDA 6.7.0. - Migrate buttons to the public component API. - Send public link messages through interaction follow-ups. - Check permissions using the interaction channel and update the changelog.
- Update Jedis to 8.0.2 and preserve legacy RESP2 behavior. - Return borrowed Redis connections to the pool after use. - Unsubscribe the Redis listener during shutdown. - Preserve the pool interface and document Redis 7.2+ support.
- Update Connector/J to 26.10.0 using its current Maven coordinates. - Add MariaDB driver selection to the Discord bot and preserve existing configuration support. - Warn about MySQL versions older than 8.4 without blocking startup. - Inherit the root plugin version in the Discord bot. - Preserve exact Discord IDs in configuration and update the changelog.
- Update PlaceholderAPI to 2.12.3\n- Align Adventure versions for recent NMS modules while preserving the Paper 1.21.4 baseline
- Read click values from typed Adventure 5 payloads\n- Preserve support for Adventure 4 and Paper 1.21.4
- Replace legacy ampersand and section-sign color parsing with MiniMessage. - Convert bundled messages and configuration examples to custom hex color tags. - Keep configurable message color aliases and MiniMessage item serialization.
- Replace raw hex color text in bundled messages and menu examples with MiniMessage tags - Render scoreboard color wave frames using native MiniMessage color tags
- Move skull item loading and kit item conversion and serialization to the public API - Require zMenu API and fallback JAR version 1.1.2.0 - Retain the local implementation for item persistence and sound helpers
NoltoxGit
marked this pull request as draft
October 21, 2026 19:42
- Preserve edited kit stack sizes when zMenu uses the Base64 fallback - Use native MiniMessage serialization and preserve scoped item italics without polluting cached messages - Restore bold text alignment, escape click payloads and clamp scoreboard color interpolation - Render sanction feedback through MiniMessage and simplify the changelog
Maxlego08
marked this pull request as ready for review
October 22, 2026 17:22
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets Paper 1.21.4 as the minimum supported version, adds Minecraft 26.3 support and makes item, enchantment and MiniMessage handling consistent across the plugin.
Changes
minecraft:for vanilla suggestions and retain custom namespaces.9.8.2, Shadow to9.6.1and paperweight to2.0.0-beta.24, preserving GroupeZ output and API publication conventions.2.12.3, Sarah to1.26and Jedis to8.0.2. Align Adventure for recent NMS modules, add connection lifetime configuration, simplify SQLite migrations and fix Redis connection leaks and subscription shutdown.2.7, JDA6.7.0and MySQL Connector/J26.10.0. Adapt interactions and channel permission checks, add MariaDB selection, preserve exact Discord IDs and inherit the plugin version.Compatibility and migration
1.21.4+with a supported NMS module is required. Common code and API retain Java 21 bytecode; Minecraft 26.x modules use Java 25.1.1.2.0is required. The local compile-only JAR remains necessary for item persistence and sound helpers missing from the public API; no zMenu implementation classes are bundled in zEssentials.sharpnessandfire_aspect. The legacy enchantment wrapper,getEnchantments(String)andregister()remain available and deprecated;register()is a no-op.&/§codes and bare hex color text with MiniMessage tags such as<c:#ED2939>. Existingcommand-enchant-error-enchantmessages must use%enchant%.database-configuration.max-lifetimeuses seconds: an absent or negative value keeps Sarah's default,0disables age-based retirement and positive values must be at least30. Connection changes require a restart.7.2+. The bot's Connector/J supports MySQL8.4+; older MySQL versions produce a startup warning. Set the bot'sdatabase-configuration.typetoMARIADBto use its MariaDB driver; omitted values retain MySQL.Validation
1.21.4and Adventure4.20.0. Check packaged bytecode: only the 26.x NMS classes require Java 25.1.21.4/ Java 21 and Paper26.3/ Java 25 servers with zMenu1.1.2.0and PlaceholderAPI2.12.3. Forty server checks pass on each, covering datapack enchantments, item lookup and reloads, offline mailbox delivery, skull loading, kit editor save/reload and NMS hologram creation.4.20.0,4.26.1and5.2.0, covering literal text, bold width, click payloads and scoreboard color interpolation.Final client-side visual checks and a live Discord account-linking test remain pending. All diagnostic code and test servers are outside the repository.