Repository navigation
feat: calorie_result_title identifier for unique Calorie Result assertion - #4
Merged
Merged
Conversation
…tion
The header string (onboarding.result.title) is also rendered by
GoalSetupView's live-target preview card, and both screens stay mounted
in the NavigationStack — a label-based E2E expect matched 3 elements
('bound not met — found 3, exactly 1', Lionidas run_f8e763a4). A unique
identifier gives the suite a locale-free, uniqueness-safe assertion.
Lionidas-In-Place: session sess_451c34f0-ceb, user-authorized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One accessibility identifier on the Calorie Result header —
.accessibilityIdentifier("calorie_result_title")(CalorieResultView.swift:67).Modifier-chain addition only — no logic, layout, or copy changes.
Why
The header string (
onboarding.result.title→ "Estimasi target harian Anda adalah") is also rendered by GoalSetupView's live-target preview card (GoalSetupView.swift:192), and both screens stay mounted in the NavigationStack. A label-based E2E expect matched 3 elements — "bound not met — found 3, exactly 1" (Lionidas run_f8e763a4). A unique identifier gives the suite a locale-free, uniqueness-safe content assertion.Test plan