Repository navigation
feat: accessibility identifiers for onboarding E2E cases - #3
Merged
Merged
Conversation
16 identifiers across the onboarding flow + Today tab (Lionidas /implement-identifiers session sess_451c34f0-ceb, user-confirmed proposal). Modifier-chain additions only — no logic, layout, or copy changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
16 accessibility identifiers across the onboarding flow + Today tab.
Modifier-chain additions only — no logic, layout, or copy changes.
welcome_get_started_buttonWelcomeView.swift:56profile_setup_next_button,profile_setup_value_label,profile_setup_sex_option_{male,female}ProfileSetupView.swiftgoal_setup_next_button,goal_setup_activity_{sedentary..veryActive},goal_setup_goal_{lose,maintain,gain}GoalSetupView.swiftcalorie_result_create_meal_plan_button,calorie_result_edit_profile_buttonCalorieResultView.swiftmain_tab_todayMainTabView.swift:32Why
Lionidas E2E cases for the onboarding funnel (splash → welcome → profile → goal → calorie result → home) need stable, locale-free selectors; the app had zero
.accessibilityIdentifiercalls. Authored via /implement-identifiers (session sess_451c34f0-ceb), applied in-place per user instruction, isolated to this branch by the host.Notes
_\(option.rawValue)) resolve at runtime:profile_setup_sex_option_female,goal_setup_activity_active, etc.main_tab_todaysits on the tabItemText— XCUI tabItem exposure varies by iOS; label fallback remains the robust selector.