Fix Exim version detection for versions >= 4.100 - #718
Merged
Conversation
Perl's `>=` numeric comparison numifies "4.100" to 4.1, which is less than 4.97, so MailScanner wrongly assumes Exim is old and disables eximlongids. This breaks the split-spool message ID layout on any Exim >= 4.100 (e.g. after a cPanel/EA4 upgrade), leaving messages misfiled and stuck/undeletable in the queue. This replaces the naive numeric compare with a proper major.minor split comparison. Fixes MailScanner#717. Credit: diagnosis and fix approach originally posted by community member nickgr on cPanel's support forum (https://support.cpanel.net/hc/en-us/community/posts/43412185290519), confirmed independently reproduced and fixed in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perl's
>=numeric comparison numifies "4.100" to 4.1, which is less than 4.97, so MailScanner wrongly assumes Exim is old and disables eximlongids. This breaks the split-spool message ID layout on any Exim >= 4.100 (e.g. after a cPanel/EA4 upgrade), leaving messages misfiled and stuck/undeletable in the queue.This replaces the naive numeric compare with a proper major.minor split comparison.
Fixes #717.
Credit: diagnosis and fix approach originally posted by community member nickgr on cPanel's support forum (https://support.cpanel.net/hc/en-us/community/posts/43412185290519), confirmed independently reproduced and fixed in production.