fix: add output encoding in MMM-CalendarExtMiniMonth.js (CWE-79) - #23
Open
anupamme wants to merge 1 commit into
Conversation
Automated security fix generated by OrbisAI Security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The updateContentFromCalendarEvents function processes calendar event data from external sources and stores event titles without any sanitization. The event.title field flows directly from untrusted calendar sources (Google Calendar, CalDAV, ICS feeds) into the application's data model and is later rendered in the DOM, creating a stored XSS vulnerability. The affected code is
MMM-CalendarExtMiniMonth.js:165. This change is the fix I would apply.Reference: CWE-79
What changed
MMM-CalendarExtMiniMonth.jsVerification
No automated check could be run against this repository, so this change is unverified beyond review. Please treat it as a suggestion.
Automated security fix by OrbisAI Security