Skip to content

Handle missing identifiers in deprecated fields #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPrevost merged 1 commit into from
Nov 12, 2026
Merged

Handle missing identifiers in deprecated fields #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/graphql/types/record_type.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def dois
end

def deprecated_identifiers(field)
@object['identifiers'].map { |id| id['value'] if id['kind'] == field }.compact
@object['identifiers']&.map { |id| id['value'] if id['kind'] == field }&.compact
end
end
end
6 changes: 6 additions & 0 deletions test/graphql/types/record_type_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,10 @@ class RecordTypeTest < ActiveSupport::TestCase
result = record_type.file_formats
assert_equal %w[PDF EPUB], result, 'file_formats should return unique values'
end

test 'deprecated identifiers return nil when identifiers key is missing' do
record_type = Types::RecordType.send(:new, { 'title' => 'Test Record' }, {})

assert_nil record_type.isbns
end
end
Loading