Skip to content

Copy the ib flag to the device #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 2 commits into from
Oct 4, 2026
+206 −3
Merged

Copy the ib flag to the device #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b714f7d
Copy the ib flag to the device
sbryngelson Oct 1, 2026
5cea7a0
Add a regression test for IB cells in the adaptive dt
sbryngelson Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/simulation/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,7 +991,7 @@ contains

$:GPU_UPDATE(device='[alt_soundspeed, acoustic_source, num_source]')
$:GPU_UPDATE(device='[dt, sys_size, buff_size, eqn_idx, mpp_lim, bubbles_euler, hypoelasticity, alt_soundspeed, &
& avg_state, model_eqns, mixture_err, grid_geometry, cyl_coord, mp_weno, weno_eps, teno_CT, low_Mach]')
& avg_state, model_eqns, mixture_err, grid_geometry, cyl_coord, mp_weno, weno_eps, teno_CT, low_Mach, ib]')
$:GPU_UPDATE(device='[riemann_hypo_ADC, ADC_kappa, hll_u_interface, hypo_hll_interface_rhs, hypo_nc_mode]')

$:GPU_UPDATE(device='[Bx0]')
Expand Down
162 changes: 162 additions & 0 deletions tests/09FDDC81/golden-metadata.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions tests/09FDDC81/golden.txt
View file
Open in desktop

Large diffs are not rendered by default.

35 changes: 33 additions & 2 deletions toolchain/mfc/test/cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ def alter_num_fluids(dimInfo):
alter_low_Mach_correction()
if num_fluids == 1:
alter_eos()
alter_ib(dimInfo)
alter_ib(dimInfo, num_fluids=num_fluids)
if len(dimInfo[0]) > 1:
alter_igr()

Expand Down Expand Up @@ -1194,7 +1194,7 @@ def alter_ppn(dimInfo):
if ARG("rdma_mpi"):
cases.append(define_case_d(stack, "2 MPI Ranks -> RDMA MPI", {"rdma_mpi": "T"}, ppn=2))

def alter_ib(dimInfo, six_eqn_model=False, viscous=False):
def alter_ib(dimInfo, six_eqn_model=False, viscous=False, num_fluids=1):
for slip in [True, False]:
stack.push(
"IBM",
Expand Down Expand Up @@ -1328,6 +1328,37 @@ def alter_ib(dimInfo, six_eqn_model=False, viscous=False):
)
)

if len(dimInfo[0]) == 2 and not viscous and num_fluids == 1:
# IB-interior cells must not set the adaptive dt. A body moving through gas at rest carries its velocity into
# its interior, so there |u| + c exceeds anywhere in the fluid and dt shrinks ~8% if those cells are counted.
# The edges sit on cell faces and the body moves 0.2 dx, so no cell crosses the surface.
cases.append(
define_case_d(
stack,
"IBM -> Adaptive dt",
{
"ib": "T",
"num_ibs": 1,
"fd_order": 2,
"n": 49,
"cfl_adap_dt": "T",
"cfl_target": 0.5,
"n_start": 0,
"t_save": 0.04,
"t_stop": 0.04,
**{f"patch_icpp({i})%{k}": v for i in range(1, 4) for k, v in [("pres", 1.0), ("alpha_rho(1)", 1.0), ("vel(1)", 0.0)]},
"patch_ib(1)%geometry": 3,
"patch_ib(1)%x_centroid": 0.5,
"patch_ib(1)%y_centroid": 0.5,
"patch_ib(1)%length_x": 0.2,
"patch_ib(1)%length_y": 0.2,
"patch_ib(1)%slip": "F",
"patch_ib(1)%moving_ibm": 2,
"patch_ib(1)%vel(1)": 0.1,
},
)
)

if len(dimInfo[0]) == 2 and not viscous:
cases.append(
define_case_d(
Expand Down
Loading