Repository navigation
Force LBP PSP to receive OK from certain endpoints - #1147
Open
Toastbrot236 wants to merge 17 commits into
Open
Toastbrot236 wants to merge 17 commits into
Toastbrot236 wants to merge 17 commits into
Conversation
…, test invalid XML, fix level tag tests
Contributor
Author
|
I noticed that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This forces certain endpoint methods to always return
OKto LBP PSP, even if the actual response status is notOK, to not cause the client to abort login or softlock itself. The endpoints I modified for this are:Also, I added unit tests to ensure that both these and the level/user hearting endpoints do always return
OKto PSP. I initially wanted to use aServicefor this which would overwrite the response data inListenerContext, but it turns out that Bunkum, for some reason, only writes the endpoint method response there after callingService.AfterRequestHandled(), so I just modified the endpoint methods in the end. This means that non-OK responses from services (e.g. rate-limits and auth failures) will still be returned to PSP, but I hope that won't be an issue, and I don't consider this to be important enough to put more effort into.