Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
fileServer.s3.enabled, the file server's NetworkPolicy doesn't allow egress to S3 on port 443, or to STS for IRSA, so every upload and download fails when S3 is enabled. The policy only seems to open egress to MinIO, whenminio.enabledis true.Similar to the
networkPolicy.redis.externalCIDRspolicy, we default to allowing egress to any destination on 443, as standard NetworkPolicy cannot target the S3 and STS endpoints by DNS name.I also added
networkPolicy.fileServer.s3CIDRswhich can limit egress to certain CIDR ranges if people want that, for example you could restrict to the CIDR range of your S3 and STS VPC endpoints.This seems like an acceptable change as it matches how we handle the same issue with Redis, and the S3 feature doesn't work without the policy change anyway, but we could also make this "opt-in" so it's explicit instead of implicit?
Testing
helm templatewithvalues-local.yamlrenders identically before and after this change.fileServer.s3.enabled=true, the fileServer policy allows egress on 443 to any destination. Withs3CIDRsset, we add one rule per CIDR range instead.fileServer.s3.enabledis true. MinIO installs are unaffected.