Skip to content

📄 feat: Keep Hancom HWP and HWPX Output Files #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psi59 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📄 feat: Keep Hancom HWP and HWPX Output Files #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/job.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ const SUPPORTED_EXTENSIONS = new Set([
'.ics', '.ical', '.ifb', '.icalendar',
'.conf', '.env', '.gitignore', '.ini', '.properties', '.toml',
'.doc', '.docx', '.pdf', '.ppt', '.pptx', '.xls', '.xlsx',
'.odt', '.ods', '.odp', '.rtf',
'.odt', '.ods', '.odp', '.rtf', '.hwp', '.hwpx',
'.avif', '.bmp', '.gif', '.ico', '.jpeg', '.jpg', '.png',
'.tif', '.tiff', '.webp',
'.eot', '.ttf', '.woff', '.woff2',
Expand Down
15 changes: 15 additions & 0 deletions api/src/walker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,21 @@ describe('walkDir / regular file handling', () => {
expect(names).toEqual(['keep.py']);
});

it('keeps Hancom word processor documents', async () => {
await fsp.writeFile(path.join(tmpDir, 'report.hwp'), 'hwp');
await fsp.writeFile(path.join(tmpDir, 'report.hwpx'), 'hwpx');
await fsp.writeFile(path.join(tmpDir, 'UPPER.HWP'), 'hwp');

const job = makeJob();
const internals = asInternals(job);
internals.submissionDir = tmpDir;

await internals.walkDir(tmpDir, 0, new Map());

const names = internals.generatedFiles.map(f => f.name).sort();
expect(names).toEqual(['UPPER.HWP', 'report.hwp', 'report.hwpx']);
});

it('keeps supported extensionless output basenames', async () => {
await fsp.writeFile(path.join(tmpDir, 'Dockerfile'), 'FROM scratch');
await fsp.mkdir(path.join(tmpDir, 'ci'));
Expand Down