Conversation
jlnav
marked this pull request as ready for review
June 11, 2026 18:19
jlnav
marked this pull request as draft
July 8, 2026 17:57
jlnav
marked this pull request as ready for review
July 14, 2026 16:41
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## refactor/deprecate_some_allocs #1747 +/- ##
==================================================================
+ Coverage 75.91% 75.96% +0.05%
==================================================================
Files 86 86
Lines 9145 9186 +41
Branches 1405 1416 +11
==================================================================
+ Hits 6942 6978 +36
- Misses 1902 1905 +3
- Partials 301 303 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jlnav
added this pull request to stack #1779
September 14, 2026 20:49
jlnav
force-pushed
the
refactor/run_substeps_with_deprecate_exitcriteria
branch
from
September 15, 2026 15:30
999a3b9 to
e9b72e3
Compare
…sim_max=30). merge ExitCriteria and .run parameters if both exist. Display associated deprecation warnings
… to prevent state between .runs().
…lways send data packet using persis_in even if its not set
jlnav
force-pushed
the
refactor/run_substeps_with_deprecate_exitcriteria
branch
from
September 15, 2026 15:37
e9b72e3 to
695226c
Compare
…rocess bugfixes in aposmm_localopt_support resulting from opus chasing down this bug
The project() function was calling project_to_target_fidelity without the required 'd' parameter (total input dimension), which is now a required positional argument in botorch 0.17.2.
GITHUB_ENV is only set in GitHub Actions, not in local pixi environments. Default to /dev/null when GITHUB_ENV is not set.
…_cube When using APOSMM with variables_mapping that includes x_on_cube, the GenSpecs model's outputs field was being set from VOCS-derived variables instead of from the APOSMM generator's gen_specs['out']. This caused H['x_on_cube'] to be unavailable in the History array, leading to ValueError: no field of name x_on_cube. The fix moves the generator gen_specs['out'] check into set_fields_from_vocs so it runs before the VOCS fallback.
Previously, when using APOSMA with variables_mapping, the GenSpecs outputs field was set from VOCS only, missing fields like x_on_cube, local_min, etc. that are produced by the APOSMA generator. This caused tests to fail when accessing H['x_on_cube']. The fix merges the generator's gen_specs['out'] fields into the outputs alongside the VOCS-derived fields, so the History array has all needed fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ensemble.run()has already been an empty function. Passing in subsets, steps, num sims, num gens, etc. into.run()is (I think) sensible since this resembles Xopt's.step(n_points). It makes the parameters of exit criteria a description of the run instead of a description of the entire ensemble.So
ensemble.run(sim_max=2000, wallclock_max=300)is possible. Deprecates ExitCriteria. So now we save an import, a class instantiation, and a parameter for Ensemble.Also technically addresses #1127