Conversation
Member
|
It was always a matter of time :) |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1711 +/- ##
===========================================
- Coverage 88.95% 82.53% -6.43%
===========================================
Files 82 84 +2
Lines 8982 9230 +248
Branches 1393 1440 +47
===========================================
- Hits 7990 7618 -372
- Misses 750 1341 +591
- Partials 242 271 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
We should have the ability to not have to pass *on_cube around. |
jlnav
force-pushed
the
aposmm_vocs_no_process
branch
from
September 14, 2026 15:05
7477cfc to
8ec126e
Compare
jlnav
force-pushed
the
aposmm_vocs_no_process
branch
from
September 14, 2026 20:52
82f4285 to
54dcea3
Compare
…_cube When using APOSMM with variables_mapping that includes x_on_cube, the GenSpecs model's outputs field was being set from VOCS-derived variables instead of from the APOSMM generator's gen_specs['out']. This caused H['x_on_cube'] to be unavailable in the History array, leading to ValueError: no field of name x_on_cube. The fix moves the generator gen_specs['out'] check into set_fields_from_vocs so it runs before the VOCS fallback.
The project() function was calling project_to_target_fidelity without the required 'd' parameter (total input dimension), which is now a required positional argument in botorch 0.17.2.
GITHUB_ENV is only set in GitHub Actions, not in local pixi environments. Default to /dev/null when GITHUB_ENV is not set.
Previously, when using APOSMA with variables_mapping, the GenSpecs outputs field was set from VOCS only, missing fields like x_on_cube, local_min, etc. that are produced by the APOSMA generator. This caused tests to fail when accessing H['x_on_cube']. The fix merges the generator's gen_specs['out'] fields into the outputs alongside the VOCS-derived fields, so the History array has all needed fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.