Skip to content

test(api,auth,scheduler,server,email): assert mock expectations in the remaining tests #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IAmJSD merged 1 commit into from
Oct 29, 2026
+1,594 −520
Merged

test(api,auth,scheduler,server,email): assert mock expectations in the remaining tests #1594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions internal/api/handler_coverage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ func TestHandler_validateSecurityContext_Unauthorized(t *testing.T) {
func TestHandler_validateSecurityContext_CSRFFailure(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

// Setup authentication to pass (via bearer token), then CSRF to fail
mockAuth.On("ValidateSession", mock.Anything, "test-token").Return(&Session{UserID: "user-1"}, nil)
Expand Down Expand Up @@ -751,7 +752,9 @@ func TestRouter_Handlers_Coverage(t *testing.T) {
func TestHandler_listPlans_Error(t *testing.T) {
ctx := context.Background()
mockStore := new(MockConfigStore)
t.Cleanup(func() { mockStore.AssertExpectations(t) })
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "test-token").Return(adminSession, nil)
Expand All @@ -771,12 +774,14 @@ func TestHandler_listPlans_Error(t *testing.T) {
func TestHandler_getPlan_NotFound(t *testing.T) {
ctx := context.Background()
mockStore := new(MockConfigStore)
t.Cleanup(func() { mockStore.AssertExpectations(t) })
mockAuth := new(MockAuthService)

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "test-token").Return(adminSession, nil)
mockAuth.grantAdmin()
mockStore.On("GetPurchasePlan", mock.Anything, "11111111-1111-1111-1111-111111111111").Return(nil, errors.New("not found"))
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

handler := &Handler{config: mockStore, auth: mockAuth}

Expand All @@ -793,6 +798,7 @@ func TestHandler_getPlan_NotFound(t *testing.T) {
func TestHandler_deleteUser_CannotDeleteSelf(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

// Use a valid UUID format
adminID := "11111111-1111-1111-1111-111111111111"
Expand All @@ -814,48 +820,53 @@ func TestHandler_deleteUser_CannotDeleteSelf(t *testing.T) {
func TestHandler_deleteUser_Error(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
mockAuth.grantAdmin()
mockAuth.On("DeleteUser", ctx, "other-user-id").Return(errors.New("delete failed"))
mockAuth.On("DeleteUser", ctx, "22222222-2222-4222-8222-222222222222").Return(errors.New("delete failed"))

handler := &Handler{auth: mockAuth}

req := &events.LambdaFunctionURLRequest{
Headers: map[string]string{"Authorization": "Bearer admin-token"},
}

_, err := handler.deleteUser(ctx, req, "other-user-id")
assert.Error(t, err)
_, err := handler.deleteUser(ctx, req, "22222222-2222-4222-8222-222222222222")
require.Error(t, err)
assert.EqualError(t, err, "delete failed", "the store failure must surface, not an earlier validation error")
}

// Tests for handler_groups

func TestHandler_deleteGroup_DeleteFailed(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
mockAuth.grantAdmin()
mockAuth.On("DeleteGroup", ctx, "group-1").Return(errors.New("delete failed"))
mockAuth.On("DeleteGroup", ctx, "33333333-3333-4333-8333-333333333333").Return(errors.New("delete failed"))

handler := &Handler{auth: mockAuth}

req := &events.LambdaFunctionURLRequest{
Headers: map[string]string{"Authorization": "Bearer admin-token"},
}

_, err := handler.deleteGroup(ctx, req, "group-1")
assert.Error(t, err)
_, err := handler.deleteGroup(ctx, req, "33333333-3333-4333-8333-333333333333")
require.Error(t, err)
assert.EqualError(t, err, "delete failed", "the store failure must surface, not an earlier validation error")
}

// Tests for forgotPassword

func TestHandler_forgotPassword_SuccessOnError(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

// Even when RequestPasswordReset returns an error, forgotPassword should return success
// (to prevent email enumeration)
Expand Down Expand Up @@ -928,6 +939,7 @@ func TestHandler_createGroup_NoToken(t *testing.T) {
func TestHandler_createGroup_InvalidBody(t *testing.T) {
ctx := context.Background()
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
Expand Down Expand Up @@ -965,7 +977,9 @@ func TestHandler_getGroup_NoToken(t *testing.T) {
func TestHandler_deletePlan_Success(t *testing.T) {
ctx := context.Background()
mockStore := new(MockConfigStore)
t.Cleanup(func() { mockStore.AssertExpectations(t) })
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
Expand Down Expand Up @@ -1004,7 +1018,9 @@ func TestHandler_deletePlan_NoToken(t *testing.T) {
func TestHandler_deletePlan_Error(t *testing.T) {
ctx := context.Background()
mockStore := new(MockConfigStore)
t.Cleanup(func() { mockStore.AssertExpectations(t) })
mockAuth := new(MockAuthService)
t.Cleanup(func() { mockAuth.AssertExpectations(t) })

adminSession := &Session{UserID: "admin-id"}
mockAuth.On("ValidateSession", ctx, "admin-token").Return(adminSession, nil)
Expand Down
Loading
Loading