Skip to content

fix(deps): bump golang.org/x/net to v0.62.0 (GO-2026-6860, GO-2026-6866) - #1564

Merged
IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062
Oct 28, 2026
Merged

IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Why

The "Build Docker Image" jobs now fail on every PR (seen on #1461 and #1246) because govulncheck reports two new fixable advisories in golang.org/x/net:

  • GO-2026-6860 and GO-2026-6866, both fixed in v0.62.0.

Main's last CI run (7b86e38) passed only because it ran before the advisories were published. The next push to main would fail the same way.

What

go get golang.org/x/net@v0.62.0 and go mod tidy. Only go.mod and go.sum change (x/net is indirect).

Verification

  • go build ./... and go vet ./...: clean.
  • go test -short -count=1 ./...: all packages pass.
  • govulncheck@v1.1.4 -mode=binary on a freshly built ./cmd/server binary: "No vulnerabilities found."

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Included a routine maintenance update. No user-visible features, fixes, or changes to app behavior are included in this release.

govulncheck in the Docker image build now fails on these two advisories,
both fixed in x/net v0.62.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@IAmJSD
IAmJSD requested a review from cristim as a code owner October 28, 2026 00:19
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7b86e38 and 24cece4.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 1
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

go.mod updates the indirect golang.org/x/net dependency from v0.61.0 to v0.62.0.

Changes: Dependency update

Layer / File(s) Summary
Update module dependency version
go.mod
The indirect golang.org/x/net dependency version changes from v0.61.0 to v0.62.0.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested labels: type/security, type/bug

Suggested reviewers: cristim

Merge Risk: Minimal · up to 24cec

No actionable merge-blocking risk is identified for this dependency update.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the dependency update and names the advisories addressed. It matches the main change in the pull request.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE 24cece44531cb99eeda91c522ecc3dde7a97df0f

Blocking:

  • none

Non-blocking:

  • none. The only change is golang.org/x/net v0.61.0 -> v0.62.0 (indirect). Its go.mod hash in go.sum is unchanged, and v0.62.0 requires the same x/crypto v0.58.0, x/sys v0.49.0 and x/text v0.43.0 that are already pinned, so nothing else in the build list moves. The upstream diff touches only html, ipv4/ipv6, internal/socket and quic. The platform links http2/hpack/idna/httpguts/trace, and none of those changed.
  • GO-2026-5932 (x/crypto v0.58.0, no published fix) is still reported. The image gate already tolerates it, and it is not this PR's concern.

Attacked:

  • Reproduced the "Build Docker Image" gate locally. I built /app/cudly (./cmd/server) and migrate (-tags=pgx5, from the main module, as in the Dockerfile), ran govulncheck@v1.1.4 -mode=binary -format json on each, and classified the output with scripts/scan-shipped-image.sh's own classify_findings.
  • Fail-before: on origin/main's go.mod/go.sum, cudly reports FIXABLE GO-2026-6860 and FIXABLE GO-2026-6866 in x/net (fixed in v0.62.0), so the gate fails. Pass-after: on this head, cudly is clean (only GO-2026-5932, tolerated) and migrate is clean. Source-mode govulncheck ./... on the head also passes.
  • go mod tidy -diff shows no diff and go mod verify passes. go build ./..., go vet ./... and go vet -tags integration ./... are clean. go test -short -count=1 ./...: every package passes. tests/e2e is a stdlib-only module and does not depend on x/net.

Body-stale:

  • none

Reviewer: rG3. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.

IAmJSD added a commit to LeanerCloud/cloud-commitments-mcp that referenced this pull request Oct 28, 2026
…66) (#122)

Bumps golang.org/x/net from v0.61.0 to v0.62.0 (go get + go mod tidy;
only go.mod/go.sum change). Mirrors
LeanerCloud/cloud-commitments-platform#1564.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
IAmJSD added a commit to LeanerCloud/cloud-commitments-cli that referenced this pull request Oct 28, 2026
…66) (#2299)

Bumps golang.org/x/net from v0.61.0 to v0.62.0 (go get + go mod tidy;
only go.mod/go.sum change). Mirrors
LeanerCloud/cloud-commitments-platform#1564.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Local verification at 24cece44531cb99eeda91c522ecc3dde7a97df0f merged onto main (7b86e386), together with #1564 in that order (combined tree e771a910, Linux, Go 1.26.10): go build ./..., go vet with and without -tags integration, the full go test -race -short -count=1 ./..., and go test -race -tags integration -count=1 on every changed package, against Docker Postgres. All pass. CI Success and pre-commit are green on this head, with 1 approving independent review(s) on it. Nothing was run against any cloud.

@IAmJSD
IAmJSD merged commit d05a172 into LeanerCloud:main Oct 28, 2026
41 checks passed
@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Merged by IAmJSD's agent at IAmJSD's request (IAmJSD is acting owner while the maintainers are away), under the bar IAmJSD set: 1 approving independent review(s) on 24cece44, green CI, and the combined-tree verification above. Squash-merged at exactly 24cece44531cb99eeda91c522ecc3dde7a97df0f.

cristim added a commit to LeanerCloud/cloud-commitments-go that referenced this pull request Oct 28, 2026
…66) (#659)

Bumps golang.org/x/net from v0.60.0 to v0.62.0 in ci_cd_sanity_tests,
providers/azure and providers/gcp (go get + go mod tidy per module).
x/net v0.62.0 raises the minimum x/crypto, x/sys, x/text and x/sync,
so those indirect requirements move with it. Mirrors
LeanerCloud/cloud-commitments-platform#1564.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Cristian Magherusan-Stanciu <cristim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant