Skip to content

docs(changelog): drop entries for code that moved to other repos - #1455

Merged
IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/issue-344
Oct 26, 2026
Merged

IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/issue-344

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

Closes #344

Root cause

CHANGELOG.md is the shared file written before the CLI, the Go libraries/providers and the MCP server moved to their own repos. It was never adapted here, so it is the same text as the go and mcp copies and lists changes this repo does not own.

Fix

  • Header now describes the platform (API server, web frontend, deployment IaC) and says that releases up to 0.9.0 came from the single repo, with links to cloud-commitments-cli, -go and -mcp.
  • Removed from 0.3.0-0.6.0: every entry about the CLI and the provider packages (RDS/OpenSearch RI purchasing, CSV reader, instance validation, provider refactor, and so on). The version headings stay, with a line saying where those changes went. 0.6.0 keeps the license/contributing entry, since LICENSE and CONTRIBUTING.md are here.
  • Removed "Convertible RI listing in EC2 client" (0.9.0) and "Add nil checks across Azure service clients" (0.7.0). Those clients live in cloud-commitments-go now.
  • Removed "Update README Go version badge" from Unreleased. This README has no badge.
  • Kept the federation IaC Notices (terraform/, cloudformation/, arm/ and iac/ are here), the frontend console.log fix, the gocyclo, Actions pinning and git-secrets entries (.pre-commit-config.yaml, the workflows and scripts/setup-git-secrets.sh are here), and the fix(api): API key create erases an explicit max_amount of 0 before validation #980/fix(frontend): a max_amount spend cap of 0 is silently erased when a group is edited #133 spend-cap fixes.
  • Added a note that Unreleased is not a complete list of changes since 0.9.0, with a link to the merged PRs. gh release list is empty, so there is no GitHub Releases page to point to.

This does not cut a release or backfill every change since 0.9.0. Cutting a release is the maintainers' call. The mcp part (LeanerCloud/cloud-commitments-mcp#104) was closed the same way.

Verification

  • npx markdownlint-cli@0.47.0 CHANGELOG.md (the pre-commit hook's version): clean.
  • go build ./..., go vet ./... (plain and -tags integration) and tests/e2e go vet -tags e2e: pass. This PR changes docs only.
  • Secrets scan: clean, planted key flagged. scripts/test-git-secrets-allowlist.sh: 183 PASS, 0 FAIL.

🤖 Generated with Claude Code

CHANGELOG.md was the shared copy from before the CLI, the Go libraries
and the MCP server split out, so it listed changes this repo does not
own: the CLI-era 0.3.0-0.6.0 releases, the EC2 and Azure client changes,
and a README badge that does not exist here. Keep the platform entries,
say where the rest went, and say the Unreleased section is not complete
since no release has been cut after 0.9.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 59 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2a11540 and a7dc919.

Files selected for processing: 1
  • CHANGELOG.md
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@IAmJSD IAmJSD added impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm urgency/eventually No deadline effort/m Days type/docs Documentation triaged Item has been triaged labels Oct 26, 2026
@IAmJSD

IAmJSD commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Pushed a7dc919: CHANGELOG.md trimmed to this repo's entries, as described in the PR body.

@IAmJSD

IAmJSD commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE a7dc919f99deb234ba4f130262b64305a0448e76

Blocking:

  • none

Non-blocking:

  • PR body / Closes #344: the issue's second acceptance item is "either backfill and cut a release, or replace the curated CHANGELOG with a pointer to GitHub Releases". The PR does neither: it keeps the curated file and adds a pointer to the merged-PR list, because no release exists. That is a reasonable substitute, but it is a judgement call on the AC rather than a literal fix. Either the acting owner accepts the substitute (keep Closes) or this should be Refs #344 with the release/backfill decision left open.
  • CHANGELOG.md 0.6.0: "Database Savings Plans support and SP type filtering" is dropped. Fine for 0.6.0 (2025-11, pre-platform, CLI/provider code), but the platform does have Database SP support now (internal/purchase/execution.go, frontend/src/settings.ts), and nothing in Unreleased mentions it. That is the "Unreleased is not complete" caveat the PR adds, so no action needed here.

Attacked: Read the full resulting CHANGELOG.md against #344's ACs. Spot-checked that kept entries are platform-owned (RI utilization lives in internal/api/handler.go/handler_ri_exchange.go; Notices cover terraform/, cloudformation/, arm/, iac/ which are here; README has no Go version badge, so dropping that entry is correct). Checked the removed 0.3.0-0.6.0 entries predate the platform IaC/API (first appear in 0.7.0). Ran npx markdownlint-cli@0.47.0 CHANGELOG.md: clean. Docs-only diff (git diff origin/main...a7dc919f), so no Go checks needed; no fail-before applicable.

Body-stale: none

Reviewer: rD2. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.

@IAmJSD

IAmJSD commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Local verification at a7dc919f99deb234ba4f130262b64305a0448e76 merged onto main (01fb35a6), together with #1447, #1453, #1455 in that order (combined tree 92b7f1db, Linux, Go 1.26.10): go build ./..., go vet with and without -tags integration, the full go test -race -short -count=1 ./..., and go test -race -tags integration -count=1 on every changed package, against Docker Postgres. All pass. CI Success and pre-commit are green on this head, with 1 approving independent review(s) on it. Nothing was run against any cloud.

@IAmJSD
IAmJSD marked this pull request as ready for review October 26, 2026 10:45
@IAmJSD
IAmJSD requested a review from cristim as a code owner October 26, 2026 10:45
@IAmJSD
IAmJSD merged commit 529b6e3 into LeanerCloud:main Oct 26, 2026
41 checks passed
@IAmJSD

IAmJSD commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

Merged by IAmJSD's agent at IAmJSD's request (IAmJSD is acting owner while the maintainers are away), under the bar IAmJSD set: 1 approving independent review(s) on a7dc919f, green CI, and the combined-tree verification above. Squash-merged at exactly a7dc919f99deb234ba4f130262b64305a0448e76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/internal Team-internal only priority/p3 Polish / idea / may never ship severity/low Minor harm triaged Item has been triaged type/docs Documentation urgency/eventually No deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HYG-09: CHANGELOG.md is a stale, cross-repo-copied shared file [platform part]

1 participant