[cristim]

refs #53

What

normalizeRegionName knew only the retired EU (...) spellings for Ireland, Frankfurt, London, Paris and Stockholm. Recommendations using the current Europe (...) display names kept the display string as their region and never matched region-code keyed coverage. This adds the five aliases.

Proof

• New table cases in TestNormalizeRegionName fail on origin/main (5 failures) and pass with the fix.
• Mutation (Paris mapped to the wrong code): the Paris case fails.
• go test -race -count=1 ./... in providers/aws with GOWORK=off and with the workspace; golangci-lint v2.10.1 clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • AWS cost recommendations now correctly recognize Ireland, Frankfurt, London, Paris, and Stockholm regions, improving regional coverage matching.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: LeanerCloud/cloud-commitments-go
• Branch: fix/53-europe-regions
• File: .coderabbit.yaml
• Commit: c1f8286
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Essentials
• Run ID: 5b50600f-b428-4545-8484-7d8ce60a0e2d

Commits

Reviewing files that changed from the base of the PR and between 29b0809 and c1f8286.

Files selected for processing: 3

• CHANGELOG.md
• providers/aws/recommendations/converters.go
• providers/aws/recommendations/converters_test.go

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.

Walkthrough

normalizeRegionName now maps five European Cost Explorer display names to AWS region codes. Tests cover each mapping, and the changelog documents the change.

Changes: AWS region normalization

Layer / File(s)	Summary
Region mappings and validation providers/aws/recommendations/converters.go, providers/aws/recommendations/converters_test.go, CHANGELOG.md	The converter maps the Ireland, Frankfurt, London, Paris, and Stockholm display names to AWS region codes. Tests cover these mappings. The changelog records the change.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested labels: type/bug

Merge Risk: Minimal · up to c1f82

The aliases should let Cost Explorer recommendations match region-code-keyed coverage, with no actionable merge risk remaining.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title names the main change: adding aliases that map the current "Europe (...)" display names to AWS region codes in the AWS recommendations region normalization. The changeset adds five such mapp…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title names the main change: adding aliases that map the current "Europe (...)" display names to AWS region codes in the AWS recommendations region normalization. The changeset adds five such mappings in normalizeRegionName (Ireland, Frankfurt, London, Paris, Stockholm), with matching tests. The title is specific, concise, and uses the conventional prefix format. It does not list every region, but that detail is not required.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}