Skip to content

Settings search: long press on a result opens its screen - #739

Open
4di-hello wants to merge 1 commit into
LeanBitLab:mainfrom
4di-hello:feature/settings-search-jump
Open

4di-hello wants to merge 1 commit into
LeanBitLab:mainfrom
4di-hello:feature/settings-search-jump

Conversation

@4di-hello

Copy link
Copy Markdown
Contributor

A tap on a settings search result still changes the setting. A long press now opens the screen that contains the setting, scrolls to it and highlights it briefly.

Why: After finding a setting via search, there was no way to see where it lives in the menu, e.g. to look at related settings next to it.

How:

  • SettingsContainer remembers which screen (module destination) each setting comes from (screenOf(key)).
  • Search results get a long-press handler (JumpOnLongPress) that navigates there with haptic feedback; the touch is consumed so the setting itself does not toggle.
  • SearchSettingsScreen scrolls to the requested setting and highlights it for 2.5 s. The request expires after 3 s, so it never triggers later on an unrelated screen.

Tested on a Xiaomi (Android 15). Unit tests pass.

🤖 Generated with Claude Code

4di-hello added a commit to 4di-hello/LeanType that referenced this pull request Oct 26, 2026
4di-hello added a commit to 4di-hello/LeanType that referenced this pull request Oct 27, 2026
4di-hello added a commit to 4di-hello/LeanType that referenced this pull request Oct 27, 2026
@4di-hello
4di-hello force-pushed the feature/settings-search-jump branch from 5450db6 to ce5d426 Compare October 27, 2026 19:14
A tap on a search result still changes the setting. A long press opens the
screen that has the setting, scrolls to it and highlights it briefly, so it
can be found again without searching.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VuiaMhLXwhErf9shhrr1uD
@4di-hello
4di-hello force-pushed the feature/settings-search-jump branch from ce5d426 to 2d8d0fb Compare October 29, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant