Repository navigation
Conversation
DROP COLUMN followed by a checkpoint can renumber physical columns while readers still use an older catalog, causing wrong values or crashes. Keep committed column slots while readers pin the checkpoint and compact them after the readers finish. Discard unobservable rolled-back additions. Persist deferred column ID changes and restore retained physical layouts when reopening. Pad dropped slots with NULLs for subsequent inserts. Cover explicit and COPY checkpoints, repeated checkpoints, named graphs, reopening, empty tables, nested types, and rolled-back additions. Fixes LadybugDB#1525
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525.
Preserve committed physical column slots while readers pin a checkpoint, so DROP COLUMN cannot invalidate the column IDs used by older catalog versions. Defer column compaction until readers finish and persist the remapped IDs. Restore retained layouts on reopen, pad dropped columns with NULLs for new rows, and discard rolled-back additions.
Validation: 33 regression cases passed; related transaction tests: 108 passed, 4 skipped; DDL tests: 104 passed.