Skip to content

Eliminate error logging about ResultSet closing and dataset names - #1038

Merged
labkey-jeckels merged 3 commits into
release26.3-SNAPSHOTfrom
26.3_fb_errorLogging
Sep 15, 2026
Merged

labkey-jeckels merged 3 commits into
release26.3-SNAPSHOTfrom
26.3_fb_errorLogging

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Rationale

We're seeing period error logging for WNPRC prod's server:

CachedResultSet was not closed.

and

Rename the file - Cytology Automated Evaluation.query.xml to - cytologyAutomatedResults
Rename the file - Cytology Manual Evaluation.query.xml to - cytologyManualResults

along with a NPE in blood draw triggers: https://github.com/LabKey/internal-issues/issues/1576

Changes

  • Follow recommended naming conventions
  • Use try-with-resources to ensure Results are closed
  • Don't send notification email when there's no content to send

Tasks

  • Claude Code Review
  • Manual Testing - N/A
  • Test Automation - N/a

@labkey-martyp labkey-martyp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

There is one other cleanup/potential resource leak claude noted if you want to clean it up too in this PR in WNPRC_EHRController.java around line 2063

@labkey-jeckels

Copy link
Copy Markdown
Contributor Author

Looks good.

There is one other cleanup/potential resource leak claude noted if you want to clean it up too in this PR in WNPRC_EHRController.java around line 2063

That one was at least closing it in the normal code pathway. I updated it to try-with-resources.

@labkey-jeckels
labkey-jeckels merged commit 7f53cca into release26.3-SNAPSHOT Sep 15, 2026
5 of 8 checks passed
@labkey-jeckels
labkey-jeckels deleted the 26.3_fb_errorLogging branch September 15, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants