Eliminate error logging about ResultSet closing and dataset names - #1038
Merged
Merged
Conversation
labkey-jeckels
requested review from
LeviCameron1,
aschmidt34,
guyinco6nito and
labkey-martyp
September 14, 2026 03:49
labkey-martyp
approved these changes
Sep 14, 2026
labkey-martyp
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
There is one other cleanup/potential resource leak claude noted if you want to clean it up too in this PR in WNPRC_EHRController.java around line 2063
Contributor
Author
That one was at least closing it in the normal code pathway. I updated it to try-with-resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We're seeing period error logging for WNPRC prod's server:
and
along with a NPE in blood draw triggers: https://github.com/LabKey/internal-issues/issues/1576
Changes
Resultsare closedTasks