[bot] Fast-forward for 26.9.0 - #3197
Merged
Merged
Conversation
## Rationale The DataViewsPermissionsTest sometimes fails intermittently due to issues with UI impersonation. ## Related Pull Requests - <!-- list of links to related pull requests (replace this comment) --> ## Changes - changed impersonation to API - small fix for click editDataViews <!-- list of standard tasks (remove this comment to enable) ## Tasks 📍 - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix --> ---- Build: [https://teamcity.labkey.org/buildConfiguration/LabKey_267Release_Community_DailySuites_DailyAPostgres/4150155](https://teamcity.labkey.org/buildConfiguration/LabKey_267Release_Community_DailySuites_DailyAPostgres/4150155)
…3183) ## Rationale A single-jump Selenium drag can lift and drop having registered no movement, so the reorder silently does nothing. Some of the changes in this PR are already in develop due to previous test fixes. ## Related Pull Requests - LabKey/platform#8015 ## Changes - `WebDriverWrapper.keyboardDragAndDrop(WebElement, int)` drives the library's keyboard sensor instead of the mouse: Space to lift, one Arrow per step, Space to drop. - Overload taking a target element derives the step count from the two handles' sibling indexes, so call sites read like the existing `dragAndDrop(from, to)`. - `FieldSelectionDialog.repositionField` delegates to the shared helper instead of its own copy. - `LoginConfigRow.getDragHandle()` exposes a row's drag handle. On the authentication configuration page `dragHandleProps` sit on the row wrapper rather than the visible `.domain-row-handle` icon, so the handle is an ancestor of the row's component element. <!-- list of standard tasks (remove this comment to enable) ## Tasks - [ ] Claude Code Review - [ ] Manual Testing - [ ] Test Automation - [ ] Verify Fix -->
DariaBod
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated automatically.
Approve all matching PRs simultaneously.
Approval will trigger automatic merge.
View all PRs: https://internal.labkey.com/Scrumtime/Backlog/harvest-gitOpenPullRequests.view?branch=26.9_ff_bot_26.9.0