Skip to content

Don't block on import lock to queue async assay import - #8060

Open
labkey-jeckels wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_assayImportQueue
Open

labkey-jeckels wants to merge 1 commit into
release26.7-SNAPSHOTfrom
26.7_fb_assayImportQueue

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Rationale

Users are seeing an indefinite progress bar when attempting to queue an asynchronous assay import when another asynchronous background is already running. That import is taking a while because it's running an expensive transform script.

Changes

  • Don't acquire the import lock to queue the asynchronous import, since we aren't actually going to be doing the import

Tasks

  • Claude Code Review
  • Manual Testing @labkey-tchad
    • Create an assay design and set it to import in the background
    • Make the import slow - could use an expensive transform script, or add a Thread.sleep() or single-thread breakpoint in DefaultArrayRunCreator inside the section with the protocol import lock:
      if (transaction.getAuditId() == null)
    • Do some assay imports, submitting before the previous one(s) have finished running as a pipeline job
    • Make sure the progress bar dialog clears immediately instead of waiting for the current job to finish
  • Test Automation - N/A

@labkey-jeckels
labkey-jeckels changed the base branch from develop to release26.7-SNAPSHOT September 18, 2026 16:28
@labkey-jeckels labkey-jeckels changed the title Queue async assay imports faster Don't block on import lock to queue async assay import Sep 18, 2026
@labkey-jeckels labkey-jeckels self-assigned this Sep 18, 2026
@LabKey LabKey deleted a comment from github-actions Bot Sep 18, 2026
@labkey-jeckels
labkey-jeckels requested a review from a team September 18, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants