Skip to content

GitHub Issue 1579: Don't log indexing errors about very long paths - #8055

Merged
labkey-jeckels merged 2 commits into
release26.7-SNAPSHOTfrom
26.7_fb_1579_longSearchPaths
Sep 18, 2026
Merged

labkey-jeckels merged 2 commits into
release26.7-SNAPSHOTfrom
26.7_fb_1579_longSearchPaths

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Rationale

Very long directory structures on a file system can lead to lots of log error spam.

Changes

  • Don't try to persist paths that are too long
  • Switch to a warning message
  • Minor code cleanup

Tasks

  • Claude Code Review
  • Manual Testing - N/A
  • Test Automation - N/A

@labkey-jeckels labkey-jeckels added this to the 26.07 milestone Sep 16, 2026
@labkey-jeckels
labkey-jeckels requested review from a team and labkey-gokhano September 16, 2026 21:53
@labkey-jeckels labkey-jeckels self-assigned this Sep 16, 2026
"SELECT ? as parent, ? as name, ? as path, ? as lastcrawled, ? as nextcrawl\n" +
"WHERE NOT EXISTS (SELECT * FROM search.crawlcollections WHERE parent=? and name=?)");
"""
INSERT INTO search.crawlcollections (parent, name, path, lastcrawled, nextcrawl)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like just white-space clean up, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no functional change. This also clears an IDE warning about string concatenation in SQLFragment arguments that could be a SQL injection risk (though this code was totally safe as-is).

@labkey-jeckels
labkey-jeckels merged commit 83ce7c6 into release26.7-SNAPSHOT Sep 18, 2026
11 checks passed
@labkey-jeckels
labkey-jeckels deleted the 26.7_fb_1579_longSearchPaths branch September 18, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants