Study container scoping fixes - #8050
Open
labkey-klum wants to merge 7 commits into
Open
labkey-klum wants to merge 7 commits into
labkey-klum wants to merge 7 commits into
Conversation
cnathe
approved these changes
Sep 18, 2026
| Report stored = getStoredReport(descriptor.getReportId()); | ||
| Report toCheck = null != stored ? stored : report; | ||
|
|
||
| if (toCheck.canEdit(context.getUser(), context.getContainer(), errors)) |
Contributor
There was a problem hiding this comment.
should the container used in the canEdit and canShare check be the context.getContainer() or the report container? or maybe this method should check that those two are the same.
Contributor
Author
There was a problem hiding this comment.
yes, I think we want to ensure the report being updated is lives in the container that the update is originating from.
Co-authored-by: Cory Nathe <cnathe@labkey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Container scoping related fixes for study as well as new or updated automation. This PR addresses the following issues: