Skip to content

Optimize SimpleTranslator remap caching and fix rowId/Name collision - #8042

Draft
labkey-jeckels wants to merge 4 commits into
developfrom
fb_simpleTranslatorOptimization
Draft

labkey-jeckels wants to merge 4 commits into
developfrom
fb_simpleTranslatorOptimization

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Rationale

Speeds up foreign key remapping during import by keeping resolved lookups cached across rows, and fix a latent inadvertent re-lookup issue.

Changes

  • Resolved lookups stay cached for the life of the import instead of being discarded every time the per-row primary-key toggle flips.
  • Foreign key values reach title-column resolution as their own type, so only a string can match a name and a value already typed as the primary key is written through as the key it is.
  • A lookup matching no rows records and reports the miss instead of throwing on first use.
  • Tests cache retention across per-row toggle collisions across lists, sample types, data classes and user display names

Tasks

  • Claude Code Review
  • Manual Testing
  • Test Automation
  • Fix broken tests

@labkey-jeckels labkey-jeckels self-assigned this Sep 13, 2026
@labkey-jeckels labkey-jeckels changed the title Optimize SimpleTranslator caching Optimize SimpleTranslator remap caching and fix the rowId collision Sep 14, 2026
@labkey-jeckels labkey-jeckels changed the title Optimize SimpleTranslator remap caching and fix the rowId collision Optimize SimpleTranslator remap caching and fix rowId/Name collision Sep 14, 2026
@labkey-nicka labkey-nicka added this to the 26.10 milestone Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants