Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces end-to-end test suite runtime, with no change to Plugin functionality.
Tests: 676 → 644
Removed tests that duplicate coverage elsewhere:
PageBlockFormPerformancePluginsCest(inline) andBlockEditorFormCest(modal).ClassicEditorFormCestduplicatedBlockEditorFormCest, as the position logic runs onthe_contentand is editor independent. KepttestAddNewPostTypeUsingDefaultFormAfterParagraphElement, as the Classic Editor's content is generated bywpautop()and the Block Editor's bydo_blocks(), which can produce a different number of elements.ImportWhenNoKitFormsexisted in all seven importer Cests for the same shared code path. Kept onPluginSettingsToolsImporterActiveCampaignCest.24 shortcode tests now assert the shortcode built by the Visual or Text Editor modal and stop there, instead of also publishing and viewing the Page. Both modals assert the same expected shortcode, and the block and shortcode share the same
render()method, so the frontend output is already covered by the block's test. AddsclearClassicEditorUnsavedChangesWarning(), which clears WordPress'beforeunloadhandlers so navigating away from the unpublished Page doesn't display a browser dialog.GitHub Actions
integrations/divi-theme, and uncode and impeka only forrestrict-content/post-types.wordpress-seoandwpforms-liteare no longer installed, as no test activates them.build-assetsjob that runsnpm ci && npm run buildonce and uploads the built CSS and JS. Test jobs download that artifact instead of running npm.composer updateis nowcomposer install, so every job installs the versions incomposer.lock.npm run buildno longer runs the CSS and JS linters, which were running in every test job. Linting is nownpm run lint, and runs in the Coding Standards workflow only.Testing
Existing tests pass.
Checklist