Tests: Improve Reliability

tests/EndToEnd/broadcasts/import-export/BroadcastsToPostsSettingsCest.php

@@ -76,6 +76,9 @@ public function testEnableDisableImport(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -102,6 +105,9 @@ public function testEnableDisableImport(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -145,6 +151,9 @@ public function testSaveSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 

tests/EndToEnd/general/other/ActivateDeactivatePluginCest.php

@@ -53,6 +53,9 @@ public function testPluginActivationAndDeactivationWithOtherPlugins(EndToEndTest
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 

tests/EndToEnd/general/other/LegacyFormDropdownCest.php

@@ -139,6 +139,9 @@ public function testWarningDisplayedForLegacyDefaultFormsSetting(EndToEndTester
 		);
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Confirm the warning is no longer displayed.
 		$I->waitForElementNotVisible('#convertkit-legacy-settings-warning');
 	}

tests/EndToEnd/general/other/ReviewRequestCest.php

@@ -54,6 +54,9 @@ public function testReviewRequestOnSaveSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -83,6 +86,9 @@ public function testReviewRequestOnSaveBlankSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 

tests/EndToEnd/general/plugin-screens/PluginSettingsGeneralCest.php

@@ -149,6 +149,9 @@ public function testValidCredentials(EndToEndTester $I)
 		// Save Changes to confirm credentials are not lost.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -270,6 +273,7 @@ public function testChangeDefaultFormSettingAndPreviewFormLinks(EndToEndTester $
 
 		// Setup Plugin, without defining default Forms.
 		$I->setupKitPluginNoDefaultForms($I);
+		$I->setupKitPluginResources($I);
 
 		// Go to the Plugin's Settings Screen.
 		$I->loadKitSettingsGeneralScreen($I);
@@ -326,6 +330,9 @@ public function testChangeDefaultFormSettingAndPreviewFormLinks(EndToEndTester $
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -349,6 +356,7 @@ public function testChangeDefaultSiteWideFormsSettingAndPreviewFormLinks(EndToEn
 	{
 		// Setup Plugin, without defining default Forms.
 		$I->setupKitPluginNoDefaultForms($I);
+		$I->setupKitPluginResources($I);
 
 		// Go to the Plugin's Settings Screen.
 		$I->loadKitSettingsGeneralScreen($I);
@@ -404,6 +412,9 @@ public function testChangeDefaultSiteWideFormsSettingAndPreviewFormLinks(EndToEn
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -431,6 +442,7 @@ public function testChangeDefaultFormPositionAfterElementSetting(EndToEndTester
 	{
 		// Setup Plugin, without defining default Forms.
 		$I->setupKitPluginNoDefaultForms($I);
+		$I->setupKitPluginResources($I);
 
 		// Go to the Plugin's Settings Screen.
 		$I->loadKitSettingsGeneralScreen($I);
@@ -476,6 +488,9 @@ public function testChangeDefaultFormPositionAfterElementSetting(EndToEndTester
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -530,6 +545,7 @@ public function testPublicPrivateCustomPostTypeSettingsExist(EndToEndTester $I)
 
 		// Setup Plugin, without defining default Forms.
 		$I->setupKitPluginNoDefaultForms($I);
+		$I->setupKitPluginResources($I);
 
 		// Go to the Plugin's Settings Screen.
 		$I->loadKitSettingsGeneralScreen($I);
@@ -547,6 +563,9 @@ public function testPublicPrivateCustomPostTypeSettingsExist(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -638,6 +657,9 @@ public function testRecaptchaSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -654,6 +676,9 @@ public function testRecaptchaSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -704,6 +729,9 @@ public function testCloudflareTurnstileSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -718,6 +746,9 @@ public function testCloudflareTurnstileSettings(EndToEndTester $I)
 		$I->clearField('#cloudflare_turnstile_secret_key');
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -748,6 +779,9 @@ public function testEnableAndDisableDebugSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -760,6 +794,9 @@ public function testEnableAndDisableDebugSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -789,6 +826,9 @@ public function testEnableAndDisableJavaScriptSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -801,6 +841,9 @@ public function testEnableAndDisableJavaScriptSettings(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -831,6 +874,9 @@ public function testEnableAndDisableCSSSetting(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -852,6 +898,9 @@ public function testEnableAndDisableCSSSetting(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -888,6 +937,9 @@ public function testEnableAndDisableAddNewLandingPageMemberContentButtonSetting(
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -900,6 +952,9 @@ public function testEnableAndDisableAddNewLandingPageMemberContentButtonSetting(
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -930,6 +985,9 @@ public function testEnableAndDisableUsageTrackingSetting(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -942,6 +1000,9 @@ public function testEnableAndDisableUsageTrackingSetting(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -993,6 +1054,9 @@ public function testSettingsScreenWhenNoResources(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -1011,6 +1075,9 @@ public function testSettingsScreenWhenNoResources(EndToEndTester $I)
 		// Click the Save Changes button.
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 

tests/EndToEnd/general/plugin-screens/PluginSettingsMCPCest.php

@@ -55,6 +55,9 @@ public function testEnableAndDisableMCPServerSetting(EndToEndTester $I)
 		$I->checkOption('#enabled');
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -70,6 +73,9 @@ public function testEnableAndDisableMCPServerSetting(EndToEndTester $I)
 		$I->uncheckOption('#enabled');
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 
@@ -115,6 +121,9 @@ public function testGenerateAndRevokeApplicationPassword(EndToEndTester $I)
 		$I->checkOption('#enabled');
 		$I->click('Save Changes');
 
+		// Wait for the settings to save.
+		$I->waitForElementVisible('#setting-error-settings_updated');
+
 		// Check that no PHP warnings or notices were output.
 		$I->checkNoWarningsAndNoticesOnScreen($I);
 

tests/EndToEnd/integrations/elementor/ElementorBroadcastsCest.php

@@ -44,8 +44,14 @@ public function testBroadcastsWidgetIsRegistered(EndToEndTester $I)
 		// Click Edit with Elementor button.
 		$I->click('#elementor-switch-mode-button');
 
+		// Wait for Elementor to load, as its loading overlay covers the widget panel,
+		// which makes the panel's search field not interactable.
+		$I->waitForElementVisible('#elementor-preview-iframe');
+		$I->waitForElementNotVisible('#elementor-loading');
+
 		// Search for the Kit Broadcasts block.
-		$I->waitForElementVisible('#elementor-panel-elements-search-input');
+		$I->waitForElementVisible('#elementor-panel-page-elements .elementor-element');
+		$I->waitForElementClickable('#elementor-panel-elements-search-input');
 		$I->fillField('#elementor-panel-elements-search-input', 'Kit Broadcasts');
 
 		// Confirm that the Broadcasts widget is displayed as an option.
@@ -70,8 +76,14 @@ public function testBroadcastsWidgetConditionalFields(EndToEndTester $I)
 		// Click Edit with Elementor button.
 		$I->click('#elementor-switch-mode-button');
 
+		// Wait for Elementor to load, as its loading overlay covers the widget panel,
+		// which makes the panel's search field not interactable.
+		$I->waitForElementVisible('#elementor-preview-iframe');
+		$I->waitForElementNotVisible('#elementor-loading');
+
 		// Search for the Kit Broadcasts block.
-		$I->waitForElementVisible('#elementor-panel-elements-search-input');
+		$I->waitForElementVisible('#elementor-panel-page-elements .elementor-element');
+		$I->waitForElementClickable('#elementor-panel-elements-search-input');
 		$I->fillField('#elementor-panel-elements-search-input', 'Kit Broadcasts');
 
 		// Insert the Broadcasts widget.

tests/EndToEnd/integrations/elementor/ElementorFormCest.php

@@ -46,8 +46,14 @@ public function testFormWidgetIsRegistered(EndToEndTester $I)
 		// Click Edit with Elementor button.
 		$I->click('#elementor-switch-mode-button');
 
+		// Wait for Elementor to load, as its loading overlay covers the widget panel,
+		// which makes the panel's search field not interactable.
+		$I->waitForElementVisible('#elementor-preview-iframe');
+		$I->waitForElementNotVisible('#elementor-loading');
+
 		// Search for the Kit Form block.
-		$I->waitForElementVisible('#elementor-panel-elements-search-input');
+		$I->waitForElementVisible('#elementor-panel-page-elements .elementor-element');
+		$I->waitForElementClickable('#elementor-panel-elements-search-input');
 		$I->fillField('#elementor-panel-elements-search-input', 'Kit Form');
 
 		// Confirm that the Form widget is displayed as an option.