Repository navigation
Fix non-determinism source in park bases and reworked AI generated comments - #3995
Merged
Merged
Conversation
wadoon
reviewed
Oct 19, 2026
wadoon
reviewed
Oct 19, 2026
wadoon
approved these changes
Oct 19, 2026
…nts to be readable
…s (additional hardening against non-determinism, but the fix in ParkBases solves that independently of existience of collissions)
unp1
force-pushed
the
bubel/fix-nondet-parkbases
branch
from
October 19, 2026 12:50
b91bb95 to
fc657ca
Compare
unp1
force-pushed
the
bubel/fix-nondet-parkbases
branch
from
October 19, 2026 13:24
fc657ca to
acf8811
Compare
unp1
enabled auto-merge
October 19, 2026 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of a series to rework the AI generated comments from the June/July stint.
Fixes:
The non-determinism was in the use of hashcode to decide which parked applications to park. As some
parts of the hashcode use identity hashes, collissions could differ from run to run and produce different
proofs (as far as I know that was not observed in any of our runs). This PR fixes it by storing the whole term
and using its hashcode only for a quick pre check before testing it via "equalsModRenaming".
Type of pull request
Ensuring quality
to ensure that no taclet app that should be woken is discarded.
Additional information and contact(s)
The contributions within this pull request are licensed under GPLv2, or (at your option) any later version, for inclusion in KeY.