Repository navigation
fix: apply audit quick wins (Next 16.3.5, dead deps, login catch-all, CI gates) - #38
Merged
Merged
Conversation
… CI gates) - Upgrade next 16.1.6 -> 16.3.5 (30 open Dependabot alerts, 2 critical RCE) - Remove unused @auth/core, @convex-dev/auth, swr and dead src/app/providers.tsx - Move login page to auth/login/[[...rest]] so Clerk path routing (factor-one, sso-callback, reset-password) no longer 404s - Run test:ci in deploy.yml before deploying to prod - Raise jest coverage thresholds from 10% to 33/36/28/33 - Gitignore prod-snapshot.zip and always remove it in sync:prod-to-dev - Pin Bun 1.4.2 in CI and packageManager: Bun < 1.3.14 crashes on Next 16.3 builds (oven-sh/bun#25609)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
✅ Quality Gate Results
All checks passed! 🚀 This PR is ready for review! |
|
🚀 Tests passed! Preview deployment will be available shortly. |
Vercel builds with Bun 1.3.14, which crashes (SIGILL) during page data collection on Next 16.3.x when next runs under the Bun runtime via `bun --bun`. Bun 1.3.x also fails locally with a CommonJS wrapper error. Dropping the --bun flag from the build scripts runs `next build` under Node, which Next supports, while Bun stays the package manager and script runner.
✅ Quality Gate Results
All checks passed! 🚀 This PR is ready for review! |
|
🚀 Tests passed! Preview deployment will be available shortly. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the "Today" items from the 2026-09-12 repo audit.
next16.1.6 → 16.3.5 (30 open Dependabot alerts, 2 critical unauth RCE)@auth/core,@convex-dev/auth,swrand deadsrc/app/providers.tsxauth/login/[[...rest]]so Clerk path routing (factor-one,sso-callback,reset-password) no longer 404sbun run test:ciindeploy.ymlbefore deploying to prodprod-snapshot.zipand always remove it insync:prod-to-devpackageManager(was 1.1.30 / 1.3.6 mismatch)next buildunder Node instead of the Bun runtime (dropped--bunfrombuildandanalyze)Why the build script changed
Next 16.3.x does not build under the Bun runtime on the Bun versions in play:
packageManagerpin, so the first preview deploy of this PR failed.next buildunder Node is the supported path. Bun remains the package manager and script runner;devandstartare unchanged.Verification
bun run lintcleanbunx tsc --noEmitcleanbun run test:ci93/93 passing, coverage above new thresholdsbun run buildgreen locally under Node 26