Repository navigation
Demo: cap at 10 salt attempts with a clear message when max is too low - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the demo appearing to run forever when Max iterations is set too low: it now stops after 10 salt attempts and explains what to change.

Problem
With a max well below the typical chain length, every salt is rejected. The library then tries up to 1,000 salts before giving up, and with Animate on the page replays each attempt at about half a second, so a run could take 10+ minutes and add 1,000 bars to the page.
Changes
max_attempts=10toChip(the library default stays 1,000)Testing