Repository navigation
ci: run the redaction fuzz targets on a weekly schedule - #105
Merged
Merged
Conversation
Under go test a fuzz target only replays its seeds, so FuzzRedact never fuzzed. Add a scheduled workflow for it and a new FuzzIsMultiStatement, whose property is the fail-closed side of the lexer. Closes #83
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🏁 CodeAnt Quality Gate ResultsCommit: ✅ Overall Status: PASSEDQuality Gate Details
|
CodeAnt PR Risk: Medium Risk
Assessed commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
FuzzRedactwas never run by any workflow: undergo testa fuzz target only replays its seed corpus, so the guard on the literal lexer read as covered and did nothing beyond its seeds.Fuzzworkflow runsFuzzRedactand a newFuzzIsMultiStatementweekly (Monday 03:00 UTC) and onworkflow_dispatch, with afuzztimeinput defaulting to 10m. Each target is its own matrix job. A crasher is uploaded as an artifact; committing it underanalyzer/testdata/fuzz/<target>/makesmake testreplay it from then on.FuzzIsMultiStatementcovers the fail-closed side of the lexer, the one that keeps a smuggled statement away from the EXPLAIN transaction: with no byte that can open a literal or comment, a;followed by more text must be reported.CONTRIBUTING.mddocuments the local fuzz command and how to commit a crasher;CHANGELOG.mdhas anAddedentry.Closes #83
Type of change
Checklist
make cipasses (fmt-check, vet, lint, vuln, test-race, lint-docs) across all moduleswebsite/docs/with a version marker for anything new (n/a: no public API or documented behaviour change)AGENTS.md/.sqlguard.example.ymlif a convention or config key changed (n/a: no convention changed)## [Unreleased]inCHANGELOG.mdanalyzer/middleware/reporterResult)Notes for reviewers
FuzzRedactfor 90s (about 17M executions) andFuzzIsMultiStatementfor 60s (about 14M). The workflow itself has not run on GitHub yet; trigger it once from the Actions tab after merge.FuzzIsMultiStatementonly asserts its property on input with no quote,$, comment or*bytes. The$$and backslash dual-reading cases stay pinned byTestIsMultiStatementNeedsBothReadingsand the seeds; fuzzing them would need an independent second lexer to compare against.FuzzRedactchecks span well-formedness, not that no literal byte survives in the output; that needs an oracle that knows where the literals are.CodeAnt-AI Description
Run scheduled fuzz tests for SQL redaction and statement detection
What Changed
Impact
✅ Earlier detection of SQL redaction crashes✅ Earlier detection of multi-statement handling errors✅ Reproducible fuzz failures in future tests💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.