Repository navigation
fix(ui): wire copy button of lone code blocks - #291
Merged
Merged
Conversation
A deferred section that is just a code block is the SourceView itself; wireSubtree only walked descendants, so its copy event reached nobody (seen on Android, where the tutorial defers sections).
JumpLink
force-pushed
the
work/android-copy
branch
from
November 12, 2026 17:26
ac5364e to
a7de9cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #290.
The tutorial defers sections below the fold (
deferBelowFold). A section that is only a code block IS theSourceView, andMdxView.wireSubtreewalked descendants only, so the block'scopyevent was never forwarded. The button fired_onCopy, but nothing reached the editor.Fix: wire the root itself when it is a
SourceView.Verified on a Galaxy S9: tap on the copy button of "Our first program" now puts the code in the Code tab.