Add support for @ENV as an exe preference - #815
Open
JamesWrigley wants to merge 3 commits into
Open
Conversation
This is safer than reading it from a preference or environment variable, as was done before.
Contributor
Author
|
AFAICT the failures are unrelated 👀 |
Contributor
Author
|
Debugged the CondaPkg test failures to an invalid cached build of Conda.jl being used, fixed in 44aa949 by always building PyCall. The benchmark job failure seems to be because this PR is from my fork and doesn't have privs to comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will force PythonCall to read the executable from the environment variable. Quoting the new docs:
When implementing this I also noticed that in embedded mode we set
CTX.exe_pathby the preference, which was wrong before (coincidentally fixed just now by #814 😛) and seems a bit fragile, so in 777fac8 I changed it to read it fromsys.executableinstead. Also wrapped a few functions from the stable ABI to help.