Set JULIA_PYTHONCALL_EXE instead of JULIA_PYTHONCALL_EXECUTABLE in juliacall - #814
Merged
Merged
Conversation
…liacall JuliaCall set JULIA_PYTHONCALL_EXECUTABLE, which nothing reads, so the Python executable was not visible to Julia at the process level and child Julia processes resolved a new CondaPkg environment. Fixes JuliaPy#813 Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Member
|
Yikes that's embarrassing. Thanks for the fix! |
Contributor
|
Thanks! Do you think you could cut a release please? Need it to fix my conda-forge CI |
Member
|
On my hols but will do when back next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #813.
JuliaCall set the environment variable
JULIA_PYTHONCALL_EXECUTABLE, which nothing reads, instead ofJULIA_PYTHONCALL_EXE. Since PythonCall readsJULIA_PYTHONCALL_EXE(with a Preferences fallback) to locate the Python executable, child Julia processes spawned from an embedded Julia did not see the running Python and instead resolved a fresh CondaPkg environment.This sets the correct variable at the process level before
jl_init, so it is visible both to PythonCall during initialization (e.g. when baked into a sysimage) and to any child Julia processes.