Repository navigation
Build for iOS, visionOS and the MLX trait in CI - #4
Merged
Merged
Conversation
swift test only compiles for macOS, so an availability mistake on iOS 18 or visionOS 2 could pass CI. Build each library for both platforms and reject warnings from the package's own sources. Also compile ModelRelayMLX with its trait and the Metal Toolchain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What
Two new jobs in the
Testsworkflow, on thexcode-27runner:build (iOS)/build (visionOS):xcodebuild buildforModelRelay,ModelRelayHTTP,ModelRelayCloudandModelRelayMCPagainstgeneric/platform=…. The job fails if the log has a warning fromSources/ModelRelay*/.build (MLX trait): downloads the Metal Toolchain, then runsswift build --traits MLX --target ModelRelayMLX -Xswiftc -warnings-as-errors.🤔 Why
swift testonly compiles for macOS. The package promises iOS 18 and visionOS 2 with newer Apple APIs availability-gated, and nothing checked that. TheMLXtrait was never compiled in CI either.🧪 How it was tested
Locally with Xcode 27.0:
letinSources/ModelRelay(Probe.swift:2:9: warning: …).📣 Notes for review
SWIFT_TREAT_WARNINGS_AS_ERRORS=YESon the command line applies to every target. It conflicts with-suppress-warningsin dependencies (EventSource,swift-collections), so the job filters the build log for the package's own sources instead.-skipMacroValidationis needed for dependency macros in a non-interactive build.Documentation/Releasing.mdsays.🤖 Generated with Claude Code