Skip to content

Replace Math::Min and Math::Max overloads with templated definition #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeStrout merged 1 commit into from
Sep 20, 2026
Merged

Replace Math::Min and Math::Max overloads with templated definition #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 11 additions & 33 deletions cpp/core/CS_Math.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,17 @@ namespace MiniScript {
// Static Math class - equivalent to C# Math
class Math {
public:
// Min functions - equivalent to C# Math.Min
static int32_t Min(int32_t a, int32_t b) {
return std::min(a, b);
}

static int64_t Min(int64_t a, int64_t b) {
return std::min(a, b);
}

static float Min(float a, float b) {
return std::min(a, b);
}

static double Min(double a, double b) {
return std::min(a, b);
}

// Max functions - equivalent to C# Math.Max
static int32_t Max(int32_t a, int32_t b) {
return std::max(a, b);
}

static int64_t Max(int64_t a, int64_t b) {
return std::max(a, b);
}

static float Max(float a, float b) {
return std::max(a, b);
}

static double Max(double a, double b) {
return std::max(a, b);
}
template <typename T, typename U>
static auto Min(T a, U b) {
using Common = typename std::common_type<T, U>::type;
return std::min(static_cast<Common>(a), static_cast<Common>(b));
}

template <typename T, typename U>
static auto Max(T a, U b) {
using Common = typename std::common_type<T, U>::type;
return std::max(static_cast<Common>(a), static_cast<Common>(b));
}

static double Round(double x) {
return std::round(x);
Expand Down