Repository navigation
Conversation
Less useful for preventing bad sorting plugin behavior, but more useful for most sane cases like inventory-wide item manipulation.
Owner
Author
|
May want to reimplement all of storageContents, firstEmpty, other searches. It's annoying, but the default implementations aren't great anyway, particularly on Spigot. |
Corrects slots for all, first, and firstEmpty. Still need to reimplement addItem and removeItem, then port to Spigot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the slot differences for contents vs individual items that were previously used to prevent bad sorting plugins from doing nasty things. Now throws errors when plugins try to delete items by setting invalid slots.
Closes #438