Skip to content

fix thread safety of newly parallel Benchmark #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baltzell wants to merge 1 commit into
base: development
Choose a base branch
from
Open

fix thread safety of newly parallel Benchmark #1434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common-tools/clas-utils/src/main/java/org/jlab/utils/benchmark/BenchmarkTimer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package org.jlab.utils.benchmark;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicLong;

Expand All @@ -12,8 +12,8 @@
public class BenchmarkTimer {

public static class BenchmarkMultiTimer extends BenchmarkTimer {
HashMap<Integer,Long> timeAtResume = new HashMap<>();
HashMap<Integer,Boolean> isPaused = new HashMap<>();
ConcurrentHashMap<Integer,Long> timeAtResume = new ConcurrentHashMap<>();
ConcurrentHashMap<Integer,Boolean> isPaused = new ConcurrentHashMap<>();
public BenchmarkMultiTimer(String name) { super(name); }
public void resume(int thread) {
if (!isPaused.containsKey(thread) || isPaused.get(thread)) {
Expand Down
Loading