Skip to content

fix(protocols): four more maker-side guards still say 'invalid format' #2406

Closed

Description

@JarryShaw

Is your feature request related to a problem? Please describe.

#2296 (fixed by #2405) replaced the reader's generic "invalid format" text on several _make_* builders with messages naming the rejected argument. Four more maker-side sites have the same defect but weren't in that issue's checklist, found during #2405's cross-review:

Describe the solution you'd like

Same convention as #2405: name the argument and the value/requirement instead of the generic reader-style text. The two _make_opt_pad sites are twins of MH._make_opt_pad's fix in #2405 and can likely reuse its wording.

Activity

  1. added
    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 28, 2026
  2. added this to the PyPCAPKit v1.5 milestone on Oct 28, 2026
  3. moved this to Pending in PyPCAPKiton Oct 28, 2026
  4. added
    wipWork in flight - a covering PR is open or an agent is actively on it
    and removed
    pendingAccepted and unstarted - nobody is on it and nothing blocks it
    on Oct 28, 2026
  5. moved this from Pending to WIP in PyPCAPKiton Oct 28, 2026
  6. JarryShaw commented on Oct 28, 2026

    @JarryShaw
    OwnerAuthor

    Fixed by #2407 (merged e48062c85).

  7. removed
    wipWork in flight - a covering PR is open or an agent is actively on it
    on Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues reporting a defect (set by the bug report template; a default, not an assessment)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions