Skip to content

Support combined ypub and zpub balance history - #20

Merged
dan2all merged 1 commit into
mainfrom
clawdia/balance-dual-xpub
Nov 3, 2026
Merged

dan2all merged 1 commit into
mainfrom
clawdia/balance-dual-xpub

Conversation

@EdgeClaws

Copy link
Copy Markdown
Collaborator

Summary

  • accept the two-line ypub + zpub output from Edge's View XPub Address
  • add Both / Native SegWit / Wrapped SegWit views while preserving the single-key flow
  • merge shared transactions by txid and union wallet-owned inputs/outputs
  • fetch historical prices once and reuse them across every view
  • include the selected side in CSV filenames

Safety and privacy

  • no CSP or destination changes
  • no backend, storage, URL parameters, logging, or third-party scripts
  • each key is independently verified against its own Blockbook account totals
  • seed phrases, private keys, and testnet keys remain refused

Verification

  • npm run check
    • 81/81 tests
    • build and internal/external link checks
    • Staff, Support Staff, and Public API Worker dry-runs
    • gitleaks clean
  • live local lookup with the public BIP49/BIP84 test-vector pair
    • Both: 305 transactions
    • zpub: 275 transactions
    • ypub: 30 transactions
    • both per-key balance verifications pass
    • desktop and 375px layouts have no horizontal overflow
    • single-zpub flow still hides the tabs
    • CSV names include -both or -zpub
  • independent Opus review: READY, no critical/high/medium findings

Before/after desktop and 375px screenshots are attached in the PR conversation.

@EdgeClaws

Copy link
Copy Markdown
Collaborator Author

Before / after evidence

Desktop

Before — production (combined paste fails)

Before: desktop combined ypub and zpub paste fails

After — branch preview (Both view)

After: desktop Both view for combined ypub and zpub

375px mobile

Before — production (combined paste fails)

Before: 375px combined ypub and zpub paste fails

After — branch preview (Both view, no horizontal overflow)

After: 375px Both view for combined ypub and zpub

@dan2all
dan2all merged commit 06ce0e2 into main Nov 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants