fix: recover cluster controls after request failures - #15
Open
Hanabi9248 wants to merge 2 commits into
Open
Hanabi9248 wants to merge 2 commits into
Hanabi9248 wants to merge 2 commits into
Conversation
Signed-off-by: Hanabi9248 <317387557+Hanabi9248@users.noreply.github.com>
Signed-off-by: Hanabi9248 <317387557+Hanabi9248@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding or editing a Kubernetes cluster fails, the rejection handler reads
this.$messagewith an unboundthis. It throws before showing the error or clearing the submit spinner. A failed cluster-list request also leaves the table loading overlay active.Use the existing component reference in both submit handlers and clear the list loading flag on failure. The dialog stays open so the request can be retried.
Added component tests using axios-mock-adapter for both failed submissions, a failed list request, and a successful list response. On the original code, three tests fail; with this change, all 8 tests across 3 suites pass on Node 18 (
vue-cli-service test:unit --runInBand). ESLint reports no errors and one warning for the test’s fixed method-name table. No backend deployment was tested.