Repository navigation
Windfarer Integration - #63
DerToaster98 wants to merge 53 commits into
Conversation
Intybyte
left a comment
Intybyte
left a comment
There was a problem hiding this comment.
A few nitpicks, also after you did testing let me know if everything works as expected, if yes I will merge, but not sure how much i can upkeep this section as i don't know your plugin like movecraft
Thank you for the review. I will begin with testing once your nitpicks have been adressed. As for maintenance, personally i think Movecraft doesn't have that much of a future, as far as I can tell from writing the integration here, Windfarer behaves mostly similar to Movecraft. I wrote the integration to make use of newer APIs and to make it more performant with Windfarer. |
Intybyte
left a comment
Intybyte
left a comment
There was a problem hiding this comment.
More nitpicks after another review, after those it should be fine codewise
|
does this close #62 ? so i can link it |
it potentially does, i have contact to that person, so, once i got cannons to build, i'll give them a test build as well |
…s provided dependency
Uses the DataTag API present in modern movecraft!
Added a TODO comment regarding a new approach for cannon detection and noted the current limitations of the cannon cache.
… hitbox; Fix typo in translation handler
|
Intybyte
left a comment
Intybyte
left a comment
There was a problem hiding this comment.
A bit curious about your serialize/deserialize.
The remaining sonarqube warnings are useless whining so it is ready to merge, the code looks good
I just need to find the time to test it with classic movecraft, so users that are using that don't experience problems, unless you already did it during the testing session
Sounds good. Deserialize => Loading code for loading this general object from a YAML file. In windfarer and addons we make more or less heavy use of Bukkit's serialization API as it makes stuff more readable for our taste. Serialize => at the moment this is not used, but needed for future features such as writing crafts to files or database and reading them from that (serializing it's type is also part of this). The "clone" function in CraftTypeProperties is used when a craft makes changes to it's own "pseudo copy" of it's crafttype. That's API that can be used by third party addons or Windfarer itself to modify craft-properties on a per-craft-instance basis, one of our developers wanted to be able to do that. |
Adds integration code for the Windfarer Movecraft derivate.
Needs to be tested, but it should work in theory. Sadly due to the fact that Movecraft and Windfarer share certain classes, a few little ugly workarounds are necessary.
Let me know what you think of it.