Repository navigation
No Python file under artifactbench/ or scripts/ contains a maintainer path (/home/unohee, /media/unohee): FSTModel takes - #13
Open
unohee wants to merge 1 commit into
Conversation
The installable package hard-coded locations that exist only on the maintainer's machine, so `--model fst` (RESULTS_8WAY.md) could not run from a fresh clone and the v1.2 tools silently looked in someone else's home directory. - models/fst.py: FSTModel takes the clone from fst_repo or ARTIFACTBENCH_FST_REPO and raises a ValueError naming both when neither is set (no default). - bench.py: --fst-repo, --fst-stage1-ckpt, --fst-stage2-ckpt wired into FSTModel; the parser moved into build_parser() so the wiring is unit-tested. - v12/model_assets.py: asset_location() no longer has maintainer defaults for the ArtifactNet, CLAM and FST trees; unset variables raise with their name. - v12/freeze.py: --artifactnet-repo / ARTIFACTBENCH_ARTIFACTNET_REPO for the exposure audit (content hashes still pin the inputs). - rerun_current.py: --artifactnet-repo and --fma-full-root (env ARTIFACTBENCH_ARTIFACTNET_REPO / ARTIFACTBENCH_FMA_FULL_ROOT); the fma root is only required with --recover-fma-from. - RESULTS_8WAY.md: fenced 8-way command with --fst-repo; check_docs.py now covers RESULTS_8WAY.md (links and flags); README and REPRODUCING_v1.2.md updated. - tests/test_external_asset_locations.py: FST error path, env/arg precedence, CLI wiring, pinned-asset and rerun errors, and a scan that fails on any /home|/Users|/media|/Volumes|/mnt/<name>/ literal under artifactbench/ and scripts/. Assumption: maintainer workflows keep working by exporting the variables already documented in docs/REPRODUCING_v1.2.md; no behaviour beyond the location lookup changed. Historical command transcripts in docs/ARTIFACTNET_FROZEN_REPLAY_v1.2.md and paper/README.md still show maintainer paths; they are records of past runs, outside this goal's scope (Python files only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone of an auto-claude run.
Check:
systemd-run --user --scope -q -p MemoryMax=6G ~/RTX_ENV/bin/python -m pytest -m "not slow" -q -p no:cacheprovider && ~/RTX_ENV/bin/python scripts/check_docs.py && ! grep -rnE "/home/unohee|/media/unohee" artifactbench scripts --include='*.py' && ~/RTX_ENV/bin/python -m artifactbench.bench --help | grep -q -- "--fst-repo" && grep -q "RESULTS_8WAY.md" scripts/check_docs.py && grep -q -- "--fst-repo" RESULTS_8WAY.mdPlan: .claude/auto-plan.md (local to the run).