Skip to content

imuIdSystem: update API endpoint to ups.im-apps.net - #26

Open
kunaisn wants to merge 1 commit into
masterfrom
agent/imuid-update-endpoint-to-ups
Open

kunaisn wants to merge 1 commit into
masterfrom
agent/imuid-update-endpoint-to-ups

Conversation

@kunaisn

@kunaisn kunaisn commented Nov 4, 2026 •

Copy link
Copy Markdown

Type of change

  • Refactoring

Description of change

imuId の送信先を sync6.im-apps.net から ups.im-apps.net に変更します。

  • modules/imuIdSystem.js:27:apiDomain を変更
  • test/spec/modules/imuIdSystem_spec.js:86:URL の正規表現を変更

sync6 との比較

同じ cookie で sync6 と ups を比べました。

一致した点:

  • uid・ppid
  • CORS(Origin をそのまま返す、credentials 許可)、Cache-Control: private, max-age=1800、Vary: Origin
  • DNT では、どちらも {"ppid":"","uid":""} を返す

Other information

テスト結果:

  • npx gulp test-only-nobuild --file test/spec/modules/imuIdSystem_spec.js:21件成功
  • npx gulp lint --nolintfix --files modules/imuIdSystem.js,test/spec/modules/imuIdSystem_spec.js:成功

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kunaisn

kunaisn commented Nov 4, 2026

Copy link
Copy Markdown
Author

The actions actions/checkout@v7 ... are not allowed in IntimateMerger/Prebid.js because all actions must be pinned to a full-length commit SHA.

prebidがactionsのsha hashを固定してないので、即座に失敗してるらしいです

@kunaisn

kunaisn commented Nov 4, 2026 •

Copy link
Copy Markdown
Author

本家に出す時に、ざっくり考えたPR文です

タイトル: imuIdSystem: update API endpoint to ups.im-apps.net

Type of change

  • Refactoring

Description of change

Updates the default API domain of imuIdSystem from sync6.im-apps.net to ups.im-apps.net. Request parameters and the response schema remain compatible, and params.url handling is unchanged.

  • modules/imuIdSystem.js: apiDomain constant.
  • test/spec/modules/imuIdSystem_spec.js: the URL pattern asserted for the default endpoint.

When a request has no vid, the new endpoint generates one and returns it, so the module now stores the existing _im_vid cookie for visitors who do not have it yet. No module code change is needed for this.

Other information

  • npx gulp test-only --file test/spec/modules/imuIdSystem_spec.js: 21 tests pass.
  • npx gulp lint --nolintfix --files modules/imuIdSystem.js,test/spec/modules/imuIdSystem_spec.js: passes.

🤖 Generated with Claude Code

@eknis

eknis commented Nov 6, 2026

Copy link
Copy Markdown
Member

よく変わるんでわかってないですが
Type of changeってどんな選択肢に今なってますかね?
maintenanceみたいなのあったらそれがいいかも

@kunaisn

kunaisn commented Nov 6, 2026 •

Copy link
Copy Markdown
Author

@eknis
こちらの話ですよね。。。

https://github.com/prebid/Prebid.js/blob/16597b34e5d4e5b540f7450fe7b2990a7851dcb3/.github/PULL_REQUEST_TEMPLATE.md

ぱっと見なさそうですが、ラベルにはあるみたいなので、Otherのまま、ラベルの方を追加する感じが良いでしょうか?
(強いて言えばRefactoringでしょうか、、、)

https://github.com/prebid/Prebid.js/pull/15835

@eknis

eknis commented Nov 6, 2026

Copy link
Copy Markdown
Member

微妙ですねえ~
でもRefactoringでいいんじゃないでしょうか!
Otherと言われると色々考えちゃうんでそんなreview厳しくないですがわかりやすいほうがいいかなと!

@kunaisn

kunaisn commented Nov 6, 2026 •

Copy link
Copy Markdown
Author

↑上のやつをEditして、Type of changeを変えてみました!

この辺りの文脈わからないので、ニュアンスを教えていただいて助かります!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants