Conversation
…rease chunk size - Throttle url_download_report to update at most every 100ms instead of every chunk, avoiding excessive stdout write/flush overhead. - Increase the default download chunk size from 16KB to 1MB, reducing the number of read()/callback calls per file.
zivy
approved these changes
Sep 23, 2026
zivy
left a comment
zivy
left a comment
Member
There was a problem hiding this comment.
Because the download mechanism uses caching this only has an effect on the first download, but faster is always better.
Member
Author
This is a significant time improvement for the users. |
blowekamp
marked this pull request as ready for review
September 23, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the performance of
Utilities/downloaddata.pyfor downloading the tutorial data, which was spending a disproportionate amount of time on console progress updates and doing many small reads.Changes
url_download_reportto update the console at most every 100ms (usingtime.monotonic()), instead of on every chunk read. Still shows an immediate first update and always shows the final 100% line.url_download_readfrom 16KB (8192*2) to 1MB.Testing
Benchmarked downloading a 74MB file (
fib_sem_bacillus_subtilis.mha):Also ran the full
Utilities/downloaddata.py Data/ Data/manifest.jsonagainst the complete manifest to confirm all files still download and verify correctly.