Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 3 issues with the new clone logic :
URL_PREFIX evaluates to https:// (which already ends with //).
In your URL construction, you wrote "$URL_PREFIX"/"$GIT_PERSONAL_ACCESS_TOKEN". This adds an extra slash, producing an invalid URL type such as https:///token@github.com/... (instead of https://token@github.com/...).
If GIT_PERSONAL_ACCESS_TOKEN is empty, the conditional block is skipped, but the CLONE_URL variable is never created. The git clone command will therefore execute without a valid URL. CLONE_URL="$GIT_REPOSITORY" should be initialized by default.
git -C $ROOT_PROJECT_DIRECTORY clone $CLONE_URL --branch $GIT_BRANCHuses unquoted variables. If any path or the branch name contains spaces, the command will crash. Variables must be enclosed in quotes ("$...").Fix #433