Repository navigation
Conversation
Rapid Bluetooth reconnects can leave dead evdev descriptors and leave dead devices behind, causing busy looping and delaying event relaying. Remove stale devices on node creation or read failure, reject duplicate paths during retries, and remove all devices matching a deleted path. - evdevDeviceAdded(): remove existing devices for the path before adding the new node - tryAddEvdevDevice(): skip paths already in use to prevent retry queues from adding duplicate devices - poll(): treat a read error other than EAGAIN as device removal instead of ignoring it, to avoid busy looping - evdevDeviceRemoved(): remove every device matching the path, not just the first one Fixes InputActions/discussions#492
Member
|
The logic is too complicated, inotify clearly isn't the right approach for this. Libinput uses udev internally so that's what I switched to in #26. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rapid Bluetooth reconnects can leave dead evdev descriptors and leave dead devices behind, causing busy looping and delaying event relaying.
Remove stale devices on node creation or read failure, reject duplicate paths during retries, and remove all devices matching a deleted path.
evdevDeviceAdded(): remove existing devices for the path before adding the new nodetryAddEvdevDevice(): skip paths already in use to prevent retry queues from adding duplicate devicespoll(): treat a read error other than EAGAIN as device removal instead of ignoring it, to avoid busy loopingevdevDeviceRemoved(): remove every device matching the path, not just the first oneFixes InputActions/discussions#492