Repository navigation
chore: Add theme strings to common - #882
Merged
Merged
Conversation
|
LunarX
enabled auto-merge
November 5, 2026 15:24
NicolasBourdin88
approved these changes
Nov 5, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are present, and the localized theme labels are consistently added across the shared Android resources.
No open issues 🎉
What changed in this PR
Adds localized theme option labels to the shared Common Android resources, enabling consistent Dark, Light, and System theme choices across supported locales.
Changes:
- Added
themeDark,themeLight, andthemeSystemto the default English resources. - Added corresponding translations for all supported locales.
- Kept the new resources alongside the existing theme strings.
| File | Description |
|---|---|
Common/src/main/res/values/strings.xml |
Adds English theme option labels. |
Common/src/main/res/values-sv/strings.xml |
Adds Swedish theme translations. |
Common/src/main/res/values-pt/strings.xml |
Adds Portuguese theme translations. |
Common/src/main/res/values-pl/strings.xml |
Adds Polish theme translations. |
Common/src/main/res/values-nl/strings.xml |
Adds Dutch theme translations. |
Common/src/main/res/values-nb/strings.xml |
Adds Norwegian Bokmål theme translations. |
Common/src/main/res/values-it/strings.xml |
Adds Italian theme translations. |
Common/src/main/res/values-fr/strings.xml |
Adds French theme translations. |
Common/src/main/res/values-fi/strings.xml |
Adds Finnish theme translations. |
Common/src/main/res/values-es/strings.xml |
Adds Spanish theme translations. |
Common/src/main/res/values-el/strings.xml |
Adds Greek theme translations. |
Common/src/main/res/values-de/strings.xml |
Adds German theme translations. |
Common/src/main/res/values-da/strings.xml |
Adds Danish theme translations. |
Review effort: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.